refactor(core): Consolidate execution lifecycle hooks even more + additional tests (#12898)

packages/workflow/src/Interfaces.ts

@@ -2284,7 +2284,7 @@ export interface IWorkflowExecutionDataProcess {
 	executionData?: IRunExecutionData;
 	runData?: IRunData;
 	pinData?: IPinData;
-	retryOf?: string;
+	retryOf?: string | null;
 	pushRef?: string;
 	startNodes?: StartNodeData[];
 	workflowData: IWorkflowBase;
@@ -2407,11 +2407,6 @@ export type WorkflowActivateMode =
 	| 'manual' // unused
 	| 'leadershipChange';
 
-export interface IWorkflowHooksOptionalParameters {
-	retryOf?: string;
-	pushRef?: string;
-}
-
 export namespace WorkflowSettings {
 	export type CallerPolicy = 'any' | 'none' | 'workflowsFromAList' | 'workflowsFromSameOwner';
 	export type SaveDataExecution = 'DEFAULT' | 'all' | 'none';

packages/workflow/src/WorkflowHooks.ts

@@ -1,9 +1,4 @@
-import type {
-	IWorkflowBase,
-	IWorkflowExecuteHooks,
-	IWorkflowHooksOptionalParameters,
-	WorkflowExecuteMode,
-} from './Interfaces';
+import type { IWorkflowBase, IWorkflowExecuteHooks, WorkflowExecuteMode } from './Interfaces';
 
 export class WorkflowHooks {
 	mode: WorkflowExecuteMode;
@@ -12,10 +7,6 @@ export class WorkflowHooks {
 
 	executionId: string;
 
-	pushRef?: string;
-
-	retryOf?: string;
-
 	hookFunctions: IWorkflowExecuteHooks;
 
 	constructor(
@@ -23,18 +14,11 @@ export class WorkflowHooks {
 		mode: WorkflowExecuteMode,
 		executionId: string,
 		workflowData: IWorkflowBase,
-		optionalParameters?: IWorkflowHooksOptionalParameters,
 	) {
-		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-		optionalParameters = optionalParameters || {};
-
 		this.hookFunctions = hookFunctions;
 		this.mode = mode;
 		this.executionId = executionId;
 		this.workflowData = workflowData;
-		this.pushRef = optionalParameters.pushRef;
-		// retryOf might be `null` from TypeORM
-		this.retryOf = optionalParameters.retryOf ?? undefined;
 	}
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any