admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)

Browse Source 
* 📘 Set up overloads

* 📘 Add temporary assertion

* 🔥 Remove inferrable boolean assertions

* ⏪ Undo autoformatting
This commit is contained in:
Iván Ovejero
2022-11-18 14:31:38 +01:00
committed by GitHub
parent 919cb9180d
commit 6757c9a2ea
163 changed files with 559 additions and 529 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/nodes-base/nodes/QuickBooks/QuickBooks.node.ts
View File

@@ -562,7 +562,7 @@ export class QuickBooks implements INodeType {
// ----------------------------------
const estimateId = this.getNodeParameter('estimateId', i) as string;
const download = this.getNodeParameter('download', i) as boolean;
const download = this.getNodeParameter('download', i);
if (download) {
responseData = await handleBinaryData.call(
@@ -723,7 +723,7 @@ export class QuickBooks implements INodeType {
// ----------------------------------
const invoiceId = this.getNodeParameter('invoiceId', i) as string;
const download = this.getNodeParameter('download', i) as boolean;
const download = this.getNodeParameter('download', i);
if (download) {
responseData = await handleBinaryData.call(
@@ -886,7 +886,7 @@ export class QuickBooks implements INodeType {
// ----------------------------------
const paymentId = this.getNodeParameter('paymentId', i) as string;
const download = this.getNodeParameter('download', i) as boolean;
const download = this.getNodeParameter('download', i);
if (download) {
responseData = await handleBinaryData.call(
@@ -1123,7 +1123,7 @@ export class QuickBooks implements INodeType {
}
} catch (error) {
if (this.continueOnFail()) {
const download = this.getNodeParameter('download', 0, false) as boolean;
const download = this.getNodeParameter('download', 0, false);
if (
['invoice', 'estimate', 'payment'].includes(resource) &&
['get'].includes(operation) &&
@@ -1155,7 +1155,7 @@ export class QuickBooks implements INodeType {
returnData.push(...executionData);
}
const download = this.getNodeParameter('download', 0, false) as boolean;
const download = this.getNodeParameter('download', 0, false);
if (
['invoice', 'estimate', 'payment'].includes(resource) &&