admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 19:11:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Rename button in ApiKeyCreateOrEditModal and remove redundant scope (no-changelog) (#14811)

Browse Source
This commit is contained in:
Ricardo Espinoza
2025-04-23 08:13:27 -04:00
committed by GitHub
parent ba07503286
commit 697998bcf0
4 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/src/public-api/permissions.ee/global-roles-scopes.ts
View File

@@ -33,7 +33,6 @@ export const OWNER_API_KEY_SCOPES: ApiKeyScope[] = [
'execution:delete', 'execution:delete',
'execution:read', 'execution:read',
'execution:list', 'execution:list',
'execution:get',
'credential:create', 'credential:create',
'credential:move', 'credential:move',
'credential:delete', 'credential:delete',
@@ -59,7 +58,6 @@ export const MEMBER_API_KEY_SCOPES: ApiKeyScope[] = [
'execution:delete', 'execution:delete',
'execution:read', 'execution:read',
'execution:list', 'execution:list',
'execution:get',
'credential:create', 'credential:create',
'credential:move', 'credential:move',
'credential:delete', 'credential:delete',

6
packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.test.ts
View File

@@ -329,11 +329,11 @@ describe('ApiKeyCreateOrEditModal', () => {
await fireEvent.update(labelInput, 'updated api key'); await fireEvent.update(labelInput, 'updated api key');
const editButton = getByText('Edit'); const saveButton = getByText('Save');
expect(editButton).toBeInTheDocument(); expect(saveButton).toBeInTheDocument();
await fireEvent.click(editButton); await fireEvent.click(saveButton);
expect(apiKeysStore.updateApiKey).toHaveBeenCalledWith('123', { expect(apiKeysStore.updateApiKey).toHaveBeenCalledWith('123', {
label: 'updated api key', label: 'updated api key',

6
packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.vue
View File

@@ -119,7 +119,9 @@ onMounted(() => {
const apiKey = apiKeysById[props.activeId]; const apiKey = apiKeysById[props.activeId];
label.value = apiKey.label ?? ''; label.value = apiKey.label ?? '';
apiKeyCreationDate.value = getApiKeyCreationTime(apiKey); apiKeyCreationDate.value = getApiKeyCreationTime(apiKey);
selectedScopes.value = !apiKeyScopesEnabled.value ? apiKeyStore.availableScopes : apiKey.scopes; selectedScopes.value = !apiKeyScopesEnabled.value
? apiKeyStore.availableScopes
: apiKey.scopes.filter((scope) => apiKeyStore.availableScopes.includes(scope));
} }
if (props.mode === 'new' && !apiKeyScopesEnabled.value) { if (props.mode === 'new' && !apiKeyScopesEnabled.value) {
@@ -343,7 +345,7 @@ async function handleEnterKey(event: KeyboardEvent) {
<N8nButton <N8nButton
v-if="mode === 'edit'" v-if="mode === 'edit'"
:disabled="!allFormFieldsAreSet" :disabled="!allFormFieldsAreSet"
:label="i18n.baseText('settings.api.view.modal.edit.button')" :label="i18n.baseText('settings.api.view.modal.save.button')"
@click="onEdit" @click="onEdit"
/> />
<N8nText v-if="mode === 'edit'" size="small" color="text-light">{{ <N8nText v-if="mode === 'edit'" size="small" color="text-light">{{

1
packages/frontend/editor-ui/src/plugins/i18n/locales/en.json
View File

@@ -1989,7 +1989,6 @@
"settings.api.view.modal.title.create": "Create API Key", "settings.api.view.modal.title.create": "Create API Key",
"settings.api.view.modal.title.edit": "Edit API Key", "settings.api.view.modal.title.edit": "Edit API Key",
"settings.api.view.modal.done.button": "Done", "settings.api.view.modal.done.button": "Done",
"settings.api.view.modal.edit.button": "Edit",
"settings.api.view.modal.save.button": "Save", "settings.api.view.modal.save.button": "Save",
"settings.api.scopes.placeholder": "Select", "settings.api.scopes.placeholder": "Select",
"settings.api.scopes.selectAll": "Select All", "settings.api.scopes.selectAll": "Select All",