fix(core)!: Bind worker server to IPv4 (#11087)

This commit is contained in:
Iván Ovejero
2024-10-04 12:18:26 +02:00
committed by GitHub
parent d974b015d0
commit 6a12f0c5fa
6 changed files with 53 additions and 34 deletions

View File

@@ -12,7 +12,6 @@ import { CredentialsOverwrites } from '@/credentials-overwrites';
import * as Db from '@/db';
import { CredentialsOverwritesAlreadySetError } from '@/errors/credentials-overwrites-already-set.error';
import { NonJsonBodyError } from '@/errors/non-json-body.error';
import { PortTakenError } from '@/errors/port-taken.error';
import { ServiceUnavailableError } from '@/errors/response-errors/service-unavailable.error';
import { ExternalHooks } from '@/external-hooks';
import type { ICredentialsOverwrite } from '@/interfaces';
@@ -40,6 +39,8 @@ export type WorkerServerEndpointsConfig = {
export class WorkerServer {
private readonly port: number;
private readonly address: string;
private readonly server: Server;
private readonly app: Application;
@@ -66,9 +67,15 @@ export class WorkerServer {
this.server = http.createServer(this.app);
this.port = this.globalConfig.queue.health.port;
this.address = this.globalConfig.queue.health.address;
this.server.on('error', (error: NodeJS.ErrnoException) => {
if (error.code === 'EADDRINUSE') throw new PortTakenError(this.port);
if (error.code === 'EADDRINUSE') {
this.logger.error(
`Port ${this.port} is already in use, possibly by the n8n main process server. Please set a different port for the worker server.`,
);
process.exit(1);
}
});
}
@@ -79,7 +86,7 @@ export class WorkerServer {
await this.mountEndpoints();
await new Promise<void>((resolve) => this.server.listen(this.port, resolve));
await new Promise<void>((resolve) => this.server.listen(this.port, this.address, resolve));
await this.externalHooks.run('worker.ready');