admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: lint for inefficient deep clones (#4378)

Browse Source 
* 👕 Create rule `no-json-parse-json-stringify`

* 🧪 Add tests

* 👕 Enable new rule

* 👕 FIx unrelated lint issue
This commit is contained in:
Iván Ovejero
2022-10-19 09:36:25 +02:00
committed by GitHub
parent a02e92d664
commit 6a1838d8c1
4 changed files with 77 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/@n8n_io/eslint-config/local-rules.test.js
View File

@@ -21,3 +21,33 @@ ruleTester.run('no-uncaught-json-parse', rules['no-uncaught-json-parse'], {
},
],
});
ruleTester.run('no-json-parse-json-stringify', rules['no-json-parse-json-stringify'], {
valid: [
{
code: 'deepCopy(foo)',
},
],
invalid: [
{
code: 'JSON.parse(JSON.stringify(foo))',
errors: [{ messageId: 'noJsonParseJsonStringify' }],
output: 'deepCopy(foo)',
},
{
code: 'JSON.parse(JSON.stringify(foo.bar))',
errors: [{ messageId: 'noJsonParseJsonStringify' }],
output: 'deepCopy(foo.bar)',
},
{
code: 'JSON.parse(JSON.stringify(foo.bar.baz))',
errors: [{ messageId: 'noJsonParseJsonStringify' }],
output: 'deepCopy(foo.bar.baz)',
},
{
code: 'JSON.parse(JSON.stringify(foo.bar[baz]))',
errors: [{ messageId: 'noJsonParseJsonStringify' }],
output: 'deepCopy(foo.bar[baz])',
},
],
});