fix(core): Handle Date and RegExp objects in AugmentObject (#5809)

This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-03-29 21:36:56 +02:00
committed by GitHub
parent 4f91525022
commit 6c35ffa82c
2 changed files with 34 additions and 27 deletions

View File

@@ -1,6 +1,24 @@
import type { IDataObject } from './Interfaces';
import util from 'util';
function augment<T>(value: T): T {
if (
typeof value !== 'object' ||
value === null ||
util.types.isProxy(value) ||
value instanceof RegExp
)
return value;
if (value instanceof Date) return new Date(value.valueOf()) as T;
// eslint-disable-next-line @typescript-eslint/no-use-before-define
if (Array.isArray(value)) return augmentArray(value) as T;
// eslint-disable-next-line @typescript-eslint/no-use-before-define
return augmentObject(value) as T;
}
export function augmentArray<T>(data: T[]): T[] {
let newData: unknown[] | undefined = undefined;
@@ -17,24 +35,12 @@ export function augmentArray<T>(data: T[]): T[] {
},
get(target, key: string, receiver): unknown {
const value = Reflect.get(newData !== undefined ? newData : target, key, receiver) as unknown;
if (typeof value === 'object') {
if (value === null || util.types.isProxy(value)) {
return value;
}
const newValue = augment(value);
if (newValue !== value) {
newData = getData();
if (Array.isArray(value)) {
Reflect.set(newData, key, augmentArray(value));
} else {
// eslint-disable-next-line @typescript-eslint/no-use-before-define
Reflect.set(newData, key, augmentObject(value as IDataObject));
}
return Reflect.get(newData, key);
Reflect.set(newData, key, newValue);
return newValue;
}
return value;
},
getOwnPropertyDescriptor(target, key) {
@@ -83,18 +89,13 @@ export function augmentObject<T extends object>(data: T): T {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const value = Reflect.get(target, key, receiver);
if (value !== null && typeof value === 'object') {
if (Array.isArray(value)) {
newData[key] = augmentArray(value);
} else {
newData[key] = augmentObject(value as IDataObject);
}
return newData[key];
const newValue = augment(value);
if (newValue !== value) {
Object.assign(newData, { [key]: newValue });
return newValue;
}
return value as string;
return value;
},
deleteProperty(target, key: string) {
if (key in newData) {