refactor: Apply more nodelinting rules (#3324)

* ✏️ Alphabetize lint rules

* 🔥 Remove duplicates

*  Update `lintfix` script

* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)

* 👕 Apply `node-param-operation-without-no-data-expression`

* 👕 Add exceptions

* 👕 Apply `node-param-description-weak` (#3328)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-value-duplicate` (#3331)

* 👕 Apply `node-param-description-miscased-json` (#3337)

* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)

* Rule workig as intended

* ✏️ Uncomment rules

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-duplicate` (#3338)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)

*  fix

*  exceptions

*  changed rule ignoring from file to line

* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)

* 👕 Apply `node-param-display-name-untrimmed` (#3341)

* 👕 Apply `node-param-display-name-miscased-id` (#3340)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-resource-with-plural-option` (#3342)

* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)

*  fix

*  replaced record with contact in description

*  fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-description-identical-to-name` (#3343)

* 👕 Apply `node-param-option-name-containing-star` (#3347)

* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)

* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)

*  fix

*  exceptions

* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)

* Rule working as intended

* Uncomented other rules

* 👕 Undo and add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

*  Alphabetize lint rules

*  Restore `lintfix` script

Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-05-20 23:47:24 +02:00
committed by GitHub
parent e7fa0ae883
commit 6dcdb30bf4
781 changed files with 1262 additions and 1071 deletions

View File

@@ -49,6 +49,7 @@ export class Chargebee implements INodeType {
displayName: 'Resource',
name: 'resource',
type: 'options',
noDataExpression: true,
options: [
{
name: 'Customer',
@@ -64,7 +65,6 @@ export class Chargebee implements INodeType {
},
],
default: 'invoice',
description: 'The resource to operate on.',
},
@@ -76,6 +76,7 @@ export class Chargebee implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -91,7 +92,6 @@ export class Chargebee implements INodeType {
},
],
default: 'create',
description: 'The operation to perform.',
},
// ----------------------------------
@@ -116,7 +116,7 @@ export class Chargebee implements INodeType {
placeholder: 'Add Property',
options: [
{
displayName: 'User Id',
displayName: 'User ID',
name: 'id',
type: 'string',
default: '',
@@ -203,8 +203,8 @@ export class Chargebee implements INodeType {
displayName: 'Operation',
name: 'operation',
default: 'list',
description: 'The operation to perform.',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -279,6 +279,7 @@ export class Chargebee implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
options: [
{
name: 'Is',
@@ -318,6 +319,7 @@ export class Chargebee implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
options: [
{
name: 'Is',
@@ -366,7 +368,7 @@ export class Chargebee implements INodeType {
// invoice:pdfUrl
// ----------------------------------
{
displayName: 'Invoice Id',
displayName: 'Invoice ID',
name: 'invoiceId',
description: 'The ID of the invoice to get',
type: 'string',
@@ -393,6 +395,7 @@ export class Chargebee implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -413,14 +416,13 @@ export class Chargebee implements INodeType {
},
],
default: 'delete',
description: 'The operation to perform.',
},
// ----------------------------------
// subscription:cancel
// ----------------------------------
{
displayName: 'Subscription Id',
displayName: 'Subscription ID',
name: 'subscriptionId',
description: 'The ID of the subscription to cancel',
type: 'string',
@@ -459,7 +461,7 @@ export class Chargebee implements INodeType {
// subscription:delete
// ----------------------------------
{
displayName: 'Subscription Id',
displayName: 'Subscription ID',
name: 'subscriptionId',
description: 'The ID of the subscription to delete',
type: 'string',