refactor: Apply more nodelinting rules (#3324)

* ✏️ Alphabetize lint rules

* 🔥 Remove duplicates

*  Update `lintfix` script

* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)

* 👕 Apply `node-param-operation-without-no-data-expression`

* 👕 Add exceptions

* 👕 Apply `node-param-description-weak` (#3328)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-value-duplicate` (#3331)

* 👕 Apply `node-param-description-miscased-json` (#3337)

* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)

* Rule workig as intended

* ✏️ Uncomment rules

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-duplicate` (#3338)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)

*  fix

*  exceptions

*  changed rule ignoring from file to line

* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)

* 👕 Apply `node-param-display-name-untrimmed` (#3341)

* 👕 Apply `node-param-display-name-miscased-id` (#3340)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-resource-with-plural-option` (#3342)

* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)

*  fix

*  replaced record with contact in description

*  fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-description-identical-to-name` (#3343)

* 👕 Apply `node-param-option-name-containing-star` (#3347)

* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)

* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)

*  fix

*  exceptions

* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)

* Rule working as intended

* Uncomented other rules

* 👕 Undo and add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

*  Alphabetize lint rules

*  Restore `lintfix` script

Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-05-20 23:47:24 +02:00
committed by GitHub
parent e7fa0ae883
commit 6dcdb30bf4
781 changed files with 1262 additions and 1071 deletions

View File

@@ -45,6 +45,7 @@ export class Nasa implements INodeType {
displayName: 'Resource',
name: 'resource',
type: 'options',
noDataExpression: true,
options: [
{
name: 'Astronomy Picture of the Day',
@@ -99,7 +100,7 @@ export class Nasa implements INodeType {
value: 'donkiWsaEnlilSimulation',
},
{
name: 'DONKI Notifications',
name: 'DONKI Notification',
value: 'donkiNotifications',
},
{
@@ -107,12 +108,11 @@ export class Nasa implements INodeType {
value: 'earthImagery',
},
{
name: 'Earth Assets',
name: 'Earth Asset',
value: 'earthAssets',
},
],
default: 'astronomyPictureOfTheDay',
description: 'The resource to operate on',
},
// ----------------------------------
// operations
@@ -121,6 +121,7 @@ export class Nasa implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -136,12 +137,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -157,12 +158,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -178,12 +179,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -199,12 +200,12 @@ export class Nasa implements INodeType {
},
],
default: 'getAll',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -220,12 +221,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -241,12 +242,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -262,12 +263,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -283,12 +284,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -304,12 +305,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -325,12 +326,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -346,12 +347,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -367,12 +368,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -388,12 +389,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -409,12 +410,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -430,12 +431,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -451,12 +452,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -472,12 +473,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -493,12 +494,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -514,12 +515,12 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
{
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -535,7 +536,6 @@ export class Nasa implements INodeType {
},
],
default: 'get',
description: 'The operation to perform',
},
// ----------------------------------
@@ -901,6 +901,9 @@ export class Nasa implements INodeType {
displayName: 'Limit',
name: 'limit',
type: 'number',
typeOptions: {
minValue: 1,
},
description: 'Max number of results to return',
default: 20,
displayOptions: {