refactor: Apply more nodelinting rules (#3324)

* ✏️ Alphabetize lint rules

* 🔥 Remove duplicates

*  Update `lintfix` script

* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)

* 👕 Apply `node-param-operation-without-no-data-expression`

* 👕 Add exceptions

* 👕 Apply `node-param-description-weak` (#3328)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-value-duplicate` (#3331)

* 👕 Apply `node-param-description-miscased-json` (#3337)

* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)

* Rule workig as intended

* ✏️ Uncomment rules

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-duplicate` (#3338)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)

*  fix

*  exceptions

*  changed rule ignoring from file to line

* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)

* 👕 Apply `node-param-display-name-untrimmed` (#3341)

* 👕 Apply `node-param-display-name-miscased-id` (#3340)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-resource-with-plural-option` (#3342)

* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)

*  fix

*  replaced record with contact in description

*  fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-description-identical-to-name` (#3343)

* 👕 Apply `node-param-option-name-containing-star` (#3347)

* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)

* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)

*  fix

*  exceptions

* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)

* Rule working as intended

* Uncomented other rules

* 👕 Undo and add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

*  Alphabetize lint rules

*  Restore `lintfix` script

Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-05-20 23:47:24 +02:00
committed by GitHub
parent e7fa0ae883
commit 6dcdb30bf4
781 changed files with 1262 additions and 1071 deletions

View File

@@ -47,6 +47,7 @@ export class Spotify implements INodeType {
displayName: 'Resource',
name: 'resource',
type: 'options',
noDataExpression: true,
options: [
{
name: 'Album',
@@ -78,7 +79,6 @@ export class Spotify implements INodeType {
},
],
default: 'player',
description: 'The resource to operate on.',
},
// --------------------------------------------------------------------------------------------------------
@@ -90,6 +90,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -145,7 +146,6 @@ export class Spotify implements INodeType {
},
],
default: 'addSongToQueue',
description: 'The operation to perform.',
},
{
displayName: 'Resource ID',
@@ -194,6 +194,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -224,7 +225,6 @@ export class Spotify implements INodeType {
},
],
default: 'get',
description: 'The operation to perform.',
},
{
displayName: 'Album ID',
@@ -278,6 +278,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -313,7 +314,6 @@ export class Spotify implements INodeType {
},
],
default: 'get',
description: 'The operation to perform.',
},
{
displayName: 'Artist ID',
@@ -383,6 +383,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -428,7 +429,6 @@ export class Spotify implements INodeType {
},
],
default: 'add',
description: 'The operation to perform.',
},
{
displayName: 'Playlist ID',
@@ -582,6 +582,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -607,7 +608,6 @@ export class Spotify implements INodeType {
},
],
default: 'track',
description: 'The operation to perform.',
},
{
displayName: 'Track ID',
@@ -657,6 +657,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -682,6 +683,7 @@ export class Spotify implements INodeType {
displayName: 'Operation',
name: 'operation',
type: 'options',
noDataExpression: true,
displayOptions: {
show: {
resource: [
@@ -697,7 +699,6 @@ export class Spotify implements INodeType {
},
],
default: 'getFollowingArtists',
description: 'The operation to perform.',
},
{
displayName: 'Return All',