refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3432)

* ⚡ Update `lintfix` script * 👕 Remove unneeded lint exceptions * 👕 Run baseline `lintfix` * 👕 Apply `node-param-description-miscased-url` (#3441) * 👕 Apply `rule node-param-placeholder-miscased-id` (#3443) Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446) * 👕 Apply `node-param-min-value-wrong-for-limit` (#3442) Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * Apply `node-param-display-name-wrong-for-dynamic-options` (#3454) * 🔨 fix * ⚡ Fix `Assigned To` fields Co-authored-by: Michael Kret <michael.k@radency.com> * 👕 Apply `rule node-param-default-wrong-for-number` (#3453) * 👕 Apply `node-param-default-wrong-for-string` (#3452) Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * Apply `node-param-display-name-miscased` (#3449) * 🔨 fix * 🔨 exceptions * ⚡ review fixes * 👕 Apply `node-param-description-lowercase-first-char` (#3451) * ⚡ fix * ⚡ review fixes * ⚡ fix Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456) * Rule working as intended * Add rule * 🔥 Remove repetitions * 👕 Add exceptions Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * 👕 Small fix for `node-param-description-wrong-for-dynamic-options` * 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460) * 👕 Apply `node-param-description-line-break-html-tag` (#3462) * 👕 Run baseline `lintfix` * 👕 Apply `node-param-options-type-unsorted-items` (#3459) * ⚡ fix * 🔨 exceptions * Add exception for Salesmate and Zoom Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * ⚡ Restore `lintfix` command Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com> Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com> Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2025-12-18 02:21:13 +00:00 · 2022-06-03 19:23:49 +02:00
parent 58ecadf53c
commit 70ae90fa3c
501 changed files with 4668 additions and 4555 deletions
--- a/packages/nodes-base/nodes/Cisco/Webex/CiscoWebexTrigger.node.ts
+++ b/packages/nodes-base/nodes/Cisco/Webex/CiscoWebexTrigger.node.ts
@@ -58,6 +58,10 @@ export class CiscoWebexTrigger implements INodeType {
 				type: 'options',
 				noDataExpression: true,
 				options: [
+					{
+						name: '[All]',
+						value: 'all',
+					},
 					{
 						name: 'Attachment Action',
 						value: 'attachmentAction',
@@ -86,10 +90,6 @@ export class CiscoWebexTrigger implements INodeType {
 						name: 'Room',
 						value: 'room',
 					},
-					{
-						name: '[All]',
-						value: 'all',
-					},
 				],
 				default: 'meeting',
 				required: true,
--- a/packages/nodes-base/nodes/Cisco/Webex/GenericFunctions.ts
+++ b/packages/nodes-base/nodes/Cisco/Webex/GenericFunctions.ts
@@ -220,32 +220,32 @@ export function getTextBlockProperties(): INodeProperties[] {
 			},
 			options: [
 				{
-					name: 'Default',
-					value: 'default',
+					name: 'Accent',
+					value: 'accent',
+				},
+				{
+					name: 'Attention',
+					value: 'attention',
 				},
 				{
 					name: 'Dark',
 					value: 'dark',
 				},
 				{
-					name: 'Light',
-					value: 'light',
-				},
-				{
-					name: 'Accent',
-					value: 'accent',
+					name: 'Default',
+					value: 'default',
 				},
 				{
 					name: 'Good',
 					value: 'good',
 				},
 				{
-					name: 'Warning',
-					value: 'warning',
+					name: 'Light',
+					value: 'light',
 				},
 				{
-					name: 'Attention',
-					value: 'attention',
+					name: 'Warning',
+					value: 'warning',
 				},
 			],
 			default: 'default',
@@ -348,20 +348,20 @@ export function getTextBlockProperties(): INodeProperties[] {
 					value: 'default',
 				},
 				{
-					name: 'Small',
-					value: 'small',
-				},
-				{
-					name: 'Medium',
-					value: 'medium',
+					name: 'Extra Large',
+					value: 'extraLarge',
 				},
 				{
 					name: 'Large',
 					value: 'large',
 				},
 				{
-					name: 'Extra Large',
-					value: 'extraLarge',
+					name: 'Medium',
+					value: 'medium',
+				},
+				{
+					name: 'Small',
+					value: 'small',
 				},
 			],
 			default: 'default',
@@ -464,29 +464,29 @@ export function getTextBlockProperties(): INodeProperties[] {
 					value: 'default',
 				},
 				{
-					name: 'None',
-					value: 'none',
-				},
-				{
-					name: 'Small',
-					value: 'small',
-				},
-				{
-					name: 'Medium',
-					value: 'medium',
+					name: 'Extra Large',
+					value: 'extraLarge',
 				},
 				{
 					name: 'Large',
 					value: 'large',
 				},
 				{
-					name: 'Extra Large',
-					value: 'extraLarge',
+					name: 'Medium',
+					value: 'medium',
+				},
+				{
+					name: 'None',
+					value: 'none',
 				},
 				{
 					name: 'Padding',
 					value: 'padding',
 				},
+				{
+					name: 'Small',
+					value: 'small',
+				},
 			],
 			default: 'default',
 			description: 'Controls the amount of spacing between this element and the preceding element',
--- a/packages/nodes-base/nodes/Cisco/Webex/descriptions/MeetingDescription.ts
+++ b/packages/nodes-base/nodes/Cisco/Webex/descriptions/MeetingDescription.ts
@@ -348,6 +348,7 @@ export const meetingFields: INodeProperties[] = [
 				description: 'Whether or not to send emails to host and invitees',
 			},
 			{
+				// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
 				displayName: 'Site URL',
 				name: 'siteUrl',
 				type: 'options',
@@ -355,7 +356,7 @@ export const meetingFields: INodeProperties[] = [
 					loadOptionsMethod: 'getSites',
 				},
 				default: '',
-				description: 'URL of the Webex site which the meeting is created on. If not specified, the meeting is created on user\'s preferred site.',
+				description: 'URL of the Webex site which the meeting is created on. If not specified, the meeting is created on user\'s preferred site. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
 			},
 		],
 	},
@@ -603,6 +604,7 @@ export const meetingFields: INodeProperties[] = [
 				description: 'Email of a person that must be a meeting participant',
 			},
 			{
+				// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
 				displayName: 'Site URL',
 				name: 'siteUrl',
 				type: 'options',
@@ -610,7 +612,7 @@ export const meetingFields: INodeProperties[] = [
 					loadOptionsMethod: 'getSites',
 				},
 				default: '',
-				description: 'URL of the Webex site which the API lists meetings from',
+				description: 'URL of the Webex site which the API lists meetings from. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
 			},
 			{
 				displayName: 'State',
@@ -622,32 +624,32 @@ export const meetingFields: INodeProperties[] = [
 						value: 'active',
 					},
 					{
-						name: 'Scheduled',
-						value: 'scheduled',
+						name: 'Ended',
+						value: 'ended',
 					},
 					{
-						name: 'Ready',
-						value: 'ready',
-					},
-					{
-						name: 'Lobby',
-						value: 'lobby',
+						name: 'Expired',
+						value: 'expired',
 					},
 					{
 						name: 'In Progress',
 						value: 'inProgress',
 					},
 					{
-						name: 'Ended',
-						value: 'ended',
+						name: 'Lobby',
+						value: 'lobby',
 					},
 					{
 						name: 'Missed',
 						value: 'missed',
 					},
 					{
-						name: 'Expired',
-						value: 'expired',
+						name: 'Ready',
+						value: 'ready',
+					},
+					{
+						name: 'Scheduled',
+						value: 'scheduled',
 					},
 				],
 				default: '',
@@ -940,6 +942,7 @@ export const meetingFields: INodeProperties[] = [
 				description: 'Whether or not to send emails to host and invitees. It is an optional field and default value is true.',
 			},
 			{
+				// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
 				displayName: 'Site URL',
 				name: 'siteUrl',
 				type: 'options',
@@ -947,7 +950,7 @@ export const meetingFields: INodeProperties[] = [
 					loadOptionsMethod: 'getSites',
 				},
 				default: '',
-				description: 'URL of the Webex site which the meeting is created on. If not specified, the meeting is created on user\'s preferred site.',
+				description: 'URL of the Webex site which the meeting is created on. If not specified, the meeting is created on user\'s preferred site. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
 			},
 			{
 				displayName: 'Start',
--- a/packages/nodes-base/nodes/Cisco/Webex/descriptions/MeetingTranscript.ts
+++ b/packages/nodes-base/nodes/Cisco/Webex/descriptions/MeetingTranscript.ts
@@ -92,10 +92,12 @@ export const meetingTranscriptFields: INodeProperties[] = [
 				type: 'options',
 				options: [
 					{
+						// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased
 						name: 'txt',
 						value: 'txt',
 					},
 					{
+						// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased
 						name: 'vtt',
 						value: 'vtt',
 					},
--- a/packages/nodes-base/nodes/Cisco/Webex/descriptions/MessageDescription.ts
+++ b/packages/nodes-base/nodes/Cisco/Webex/descriptions/MessageDescription.ts
@@ -77,7 +77,7 @@ export const messageFields: INodeProperties[] = [
 		},
 	},
 	{
-		displayName: 'Room ID',
+		displayName: 'Room Name or ID',
 		name: 'roomId',
 		type: 'options',
 		typeOptions: {
@@ -461,9 +461,9 @@ export const messageFields: INodeProperties[] = [
 	//             message: getAll
 	// ----------------------------------------
 	{
-		displayName: 'Room ID',
+		displayName: 'Room Name or ID',
 		name: 'roomId',
-		description: 'List messages in a room, by ID',
+		description: 'List messages in a room, by ID. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
 		type: 'options',
 		typeOptions: {
 			loadOptionsMethod: 'getRooms',