refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3432)

*  Update `lintfix` script

* 👕 Remove unneeded lint exceptions

* 👕 Run baseline `lintfix`

* 👕 Apply `node-param-description-miscased-url` (#3441)

* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446)

* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454)

* 🔨 fix

*  Fix `Assigned To` fields

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `rule node-param-default-wrong-for-number` (#3453)

* 👕 Apply `node-param-default-wrong-for-string` (#3452)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* Apply `node-param-display-name-miscased` (#3449)

* 🔨 fix

* 🔨 exceptions

*  review fixes

* 👕 Apply `node-param-description-lowercase-first-char` (#3451)

*  fix

*  review fixes

*  fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456)

* Rule working as intended

* Add rule

* 🔥 Remove repetitions

* 👕 Add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460)

* 👕 Apply `node-param-description-line-break-html-tag` (#3462)

* 👕 Run baseline `lintfix`

* 👕 Apply `node-param-options-type-unsorted-items` (#3459)

*  fix

* 🔨 exceptions

* Add exception for Salesmate and Zoom

Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

*  Restore `lintfix` command

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-03 19:23:49 +02:00
committed by GitHub
parent 58ecadf53c
commit 70ae90fa3c
501 changed files with 4668 additions and 4555 deletions

View File

@@ -29,24 +29,24 @@ export const conditionFields: INodeProperties[] = [
},
options: [
{
name: 'Status',
value: 'status',
},
{
name: 'Type',
value: 'type',
},
{
name: 'Priority',
value: 'priority',
name: 'Assignee',
value: 'assignee',
},
{
name: 'Group',
value: 'group',
},
{
name: 'Assignee',
value: 'assignee',
name: 'Priority',
value: 'priority',
},
{
name: 'Status',
value: 'status',
},
{
name: 'Type',
value: 'type',
},
],
default: 'status',
@@ -57,6 +57,22 @@ export const conditionFields: INodeProperties[] = [
name: 'operation',
type: 'options',
options: [
{
name: 'Changed',
value: 'changed',
},
{
name: 'Changed From',
value: 'value_previous',
},
{
name: 'Changed To',
value: 'value',
},
{
name: 'Greater Than',
value: 'greater_than',
},
{
name: 'Is',
value: 'is',
@@ -69,34 +85,18 @@ export const conditionFields: INodeProperties[] = [
name: 'Less Than',
value: 'less_than',
},
{
name: 'Greater Than',
value: 'greater_than',
},
{
name: 'Changed',
value: 'changed',
},
{
name: 'Changed To',
value: 'value',
},
{
name: 'Changed From',
value: 'value_previous',
},
{
name: 'Not Changed',
value: 'not_changed',
},
{
name: 'Not Changed To',
value: 'not_value',
},
{
name: 'Not Changed From',
value: 'not_value_previous',
},
{
name: 'Not Changed To',
value: 'not_value',
},
],
displayOptions: {
hide: {
@@ -113,6 +113,18 @@ export const conditionFields: INodeProperties[] = [
name: 'operation',
type: 'options',
options: [
{
name: 'Changed',
value: 'changed',
},
{
name: 'Changed From',
value: 'value_previous',
},
{
name: 'Changed To',
value: 'value',
},
{
name: 'Is',
value: 'is',
@@ -121,30 +133,18 @@ export const conditionFields: INodeProperties[] = [
name: 'Is Not',
value: 'is_not',
},
{
name: 'Changed',
value: 'changed',
},
{
name: 'Changed To',
value: 'value',
},
{
name: 'Changed From',
value: 'value_previous',
},
{
name: 'Not Changed',
value: 'not_changed',
},
{
name: 'Not Changed To',
value: 'not_value',
},
{
name: 'Not Changed From',
value: 'not_value_previous',
},
{
name: 'Not Changed To',
value: 'not_value',
},
],
displayOptions: {
show: {
@@ -180,13 +180,17 @@ export const conditionFields: INodeProperties[] = [
},
options: [
{
name: 'Open',
value: 'open',
name: 'Closed',
value: 'closed',
},
{
name: 'New',
value: 'new',
},
{
name: 'Open',
value: 'open',
},
{
name: 'Pending',
value: 'pending',
@@ -195,10 +199,6 @@ export const conditionFields: INodeProperties[] = [
name: 'Solved',
value: 'solved',
},
{
name: 'Closed',
value: 'closed',
},
],
default: 'open',
},
@@ -289,6 +289,7 @@ export const conditionFields: INodeProperties[] = [
default: 'low',
},
{
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
displayName: 'Value',
name: 'value',
type: 'options',
@@ -313,6 +314,7 @@ export const conditionFields: INodeProperties[] = [
default: '',
},
{
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
displayName: 'Value',
name: 'value',
type: 'options',

View File

@@ -16,6 +16,11 @@ export const organizationOperations: INodeProperties[] = [
},
},
options: [
{
name: 'Count',
value: 'count',
description: 'Count organizations',
},
{
name: 'Create',
value: 'create',
@@ -26,11 +31,6 @@ export const organizationOperations: INodeProperties[] = [
value: 'delete',
description: 'Delete an organization',
},
{
name: 'Count',
value: 'count',
description: 'Count organizations',
},
{
name: 'Get',
value: 'get',
@@ -131,7 +131,7 @@ export const organizationFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {
@@ -240,7 +240,7 @@ export const organizationFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {

View File

@@ -128,14 +128,14 @@ export const ticketFields: INodeProperties[] = [
name: 'customFieldsValues',
values: [
{
displayName: 'ID',
displayName: 'Name or ID',
name: 'id',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getCustomFields',
},
default: '',
description: 'Custom field ID',
description: 'Custom field ID. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Value',
@@ -156,14 +156,14 @@ export const ticketFields: INodeProperties[] = [
description: 'An ID you can use to link Zendesk Support tickets to local records',
},
{
displayName: 'Group',
displayName: 'Group Name or ID',
name: 'group',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getGroups',
},
default: '',
description: 'The group this ticket is assigned to',
description: 'The group this ticket is assigned to. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Recipient',
@@ -186,7 +186,7 @@ export const ticketFields: INodeProperties[] = [
value: 'new',
},
{
name: 'On-hold',
name: 'On-Hold',
value: 'hold',
},
{
@@ -351,14 +351,14 @@ export const ticketFields: INodeProperties[] = [
name: 'customFieldsValues',
values: [
{
displayName: 'ID',
displayName: 'Name or ID',
name: 'id',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getCustomFields',
},
default: '',
description: 'Custom field ID',
description: 'Custom field ID. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Value',
@@ -379,14 +379,14 @@ export const ticketFields: INodeProperties[] = [
description: 'An ID you can use to link Zendesk Support tickets to local records',
},
{
displayName: 'Group',
displayName: 'Group Name or ID',
name: 'group',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getGroups',
},
default: '',
description: 'The group this ticket is assigned to',
description: 'The group this ticket is assigned to. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Internal Note',
@@ -423,7 +423,7 @@ export const ticketFields: INodeProperties[] = [
value: 'new',
},
{
name: 'On-hold',
name: 'On-Hold',
value: 'hold',
},
{
@@ -644,7 +644,7 @@ export const ticketFields: INodeProperties[] = [
},
options: [
{
displayName: 'Group',
displayName: 'Group Name or ID',
name: 'group',
type: 'options',
typeOptions: {
@@ -658,7 +658,7 @@ export const ticketFields: INodeProperties[] = [
},
},
default: '',
description: 'The group to search',
description: 'The group to search. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Query',
@@ -679,10 +679,6 @@ export const ticketFields: INodeProperties[] = [
name: 'sortBy',
type: 'options',
options: [
{
name: 'Updated At',
value: 'updated_at',
},
{
name: 'Created At',
value: 'created_at',
@@ -699,6 +695,10 @@ export const ticketFields: INodeProperties[] = [
name: 'Ticket Type',
value: 'ticket_type',
},
{
name: 'Updated At',
value: 'updated_at',
},
],
default: 'updated_at',
description: 'Defaults to sorting by relevance',
@@ -740,7 +740,7 @@ export const ticketFields: INodeProperties[] = [
value: 'new',
},
{
name: 'On-hold',
name: 'On-Hold',
value: 'hold',
},
{

View File

@@ -52,7 +52,6 @@ export const ticketFieldFields: INodeProperties[] = [
],
},
},
description: 'ticketField ID',
},
/* -------------------------------------------------------------------------- */

View File

@@ -137,14 +137,15 @@ export const userFields: INodeProperties[] = [
description: 'A unique identifier from another system',
},
{
displayName: 'Locale ID',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
displayName: 'Locale',
name: 'locale',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getLocales',
},
default: '',
description: 'The user\'s locale',
description: 'The user\'s locale. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Moderator',
@@ -165,17 +166,17 @@ export const userFields: INodeProperties[] = [
name: 'only_private_comments',
type: 'boolean',
default: false,
description: 'true if the user can only create private comments',
description: 'True if the user can only create private comments',
},
{
displayName: 'Organization ID',
displayName: 'Organization Name or ID',
name: 'organization_id',
typeOptions: {
loadOptionsMethod: 'getOrganizations',
},
type: 'options',
default: '',
description: 'The ID of the user\'s organization. If the user has more than one organization memberships, the ID of the user\'s default organization.',
description: 'The ID of the user\'s organization. If the user has more than one organization memberships, the ID of the user\'s default organization. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Phone',
@@ -291,14 +292,14 @@ export const userFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getUserFields',
},
default: '',
description: 'Name of the field to sort on',
description: 'Name of the field to sort on. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Value',
@@ -393,14 +394,15 @@ export const userFields: INodeProperties[] = [
description: 'A unique identifier from another system',
},
{
displayName: 'Locale ID',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options
displayName: 'Locale',
name: 'locale',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getLocales',
},
default: '',
description: 'The user\'s locale',
description: 'The user\'s locale. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Moderator',
@@ -428,17 +430,17 @@ export const userFields: INodeProperties[] = [
name: 'only_private_comments',
type: 'boolean',
default: false,
description: 'true if the user can only create private comments',
description: 'True if the user can only create private comments',
},
{
displayName: 'Organization ID',
displayName: 'Organization Name or ID',
name: 'organization_id',
typeOptions: {
loadOptionsMethod: 'getOrganizations',
},
type: 'options',
default: '',
description: 'The ID of the user\'s organization. If the user has more than one organization memberships, the ID of the user\'s default organization.',
description: 'The ID of the user\'s organization. If the user has more than one organization memberships, the ID of the user\'s default organization. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Phone',
@@ -554,14 +556,14 @@ export const userFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getUserFields',
},
default: '',
description: 'Name of the field to sort on',
description: 'Name of the field to sort on. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Value',