admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Beeminder Node): Remove unnecessary form data conversion for API token auth to work (#18133)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Mutasem Aldmour
2025-08-08 15:58:29 +02:00
committed by GitHub
parent 61f2838a90
commit 716577e282
3 changed files with 8 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
packages/nodes-base/nodes/Beeminder/GenericFunctions.ts
View File

@@ -15,26 +15,6 @@ function isValidAuthenticationMethod(value: unknown): value is 'apiToken' | 'oAu
return typeof value === 'string' && ['apiToken', 'oAuth2'].includes(value);
}
function convertToFormData(obj: any): Record<string, string> {
const result: Record<string, string> = {};
for (const [key, value] of Object.entries(obj)) {
if (value === null || value === undefined) {
// Skip null/undefined values
continue;
} else if (typeof value === 'boolean') {
result[key] = value.toString();
} else if (typeof value === 'number') {
result[key] = value.toString();
} else if (Array.isArray(value)) {
// Handle arrays - convert to JSON string for form data
result[key] = JSON.stringify(value);
} else {
result[key] = String(value);
}
}
return result;
}
export async function beeminderApiRequest(
this: IExecuteFunctions | IWebhookFunctions | IHookFunctions | ILoadOptionsFunctions,
method: IHttpRequestMethods,
@@ -42,7 +22,6 @@ export async function beeminderApiRequest(
body: any = {},
query: IDataObject = {},
useFormData: boolean = false,
): Promise<any> {
const authenticationMethod = this.getNodeParameter('authentication', 0, 'apiToken');
@@ -57,23 +36,14 @@ export async function beeminderApiRequest(
const options: IRequestOptions = {
method,
body,
qs: query,
uri: `${BEEMINDER_URI}${endpoint}`,
json: true,
};
if (useFormData) {
options.formData = convertToFormData(body);
} else {
options.body = body;
}
if (!Object.keys(body as IDataObject).length) {
if (useFormData) {
delete options.formData;
} else {
delete options.body;
}
delete options.body;
}
if (!Object.keys(query).length) {