mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 18:12:04 +00:00
fix(Google Calendar Node): Updates and fixes (#10715)
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
This commit is contained in:
@@ -1404,7 +1404,7 @@ function addToIssuesIfMissing(
|
||||
if (
|
||||
(nodeProperties.type === 'string' && (value === '' || value === undefined)) ||
|
||||
(nodeProperties.type === 'multiOptions' && Array.isArray(value) && value.length === 0) ||
|
||||
(nodeProperties.type === 'dateTime' && value === undefined) ||
|
||||
(nodeProperties.type === 'dateTime' && (value === '' || value === undefined)) ||
|
||||
(nodeProperties.type === 'options' && (value === '' || value === undefined)) ||
|
||||
((nodeProperties.type === 'resourceLocator' || nodeProperties.type === 'workflowSelector') &&
|
||||
!isValidResourceLocatorParameterValue(value as INodeParameterResourceLocator))
|
||||
|
||||
@@ -4195,4 +4195,57 @@ describe('NodeHelpers', () => {
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
describe('getParameterIssues, required parameters validation', () => {
|
||||
const testNode: INode = {
|
||||
id: '12345',
|
||||
name: 'Test Node',
|
||||
typeVersion: 1,
|
||||
type: 'n8n-nodes-base.testNode',
|
||||
position: [1, 1],
|
||||
parameters: {},
|
||||
};
|
||||
|
||||
it('Should validate required dateTime parameters if empty string', () => {
|
||||
const nodeProperties: INodeProperties = {
|
||||
displayName: 'Date Time',
|
||||
name: 'testDateTime',
|
||||
type: 'dateTime',
|
||||
default: '',
|
||||
required: true,
|
||||
};
|
||||
const nodeValues: INodeParameters = {
|
||||
testDateTime: '',
|
||||
};
|
||||
|
||||
const result = getParameterIssues(nodeProperties, nodeValues, '', testNode);
|
||||
|
||||
expect(result).toEqual({
|
||||
parameters: {
|
||||
testDateTime: ['Parameter "Date Time" is required.'],
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
it('Should validate required dateTime parameters if empty undefined', () => {
|
||||
const nodeProperties: INodeProperties = {
|
||||
displayName: 'Date Time',
|
||||
name: 'testDateTime',
|
||||
type: 'dateTime',
|
||||
default: '',
|
||||
required: true,
|
||||
};
|
||||
const nodeValues: INodeParameters = {
|
||||
testDateTime: undefined,
|
||||
};
|
||||
|
||||
const result = getParameterIssues(nodeProperties, nodeValues, '', testNode);
|
||||
|
||||
expect(result).toEqual({
|
||||
parameters: {
|
||||
testDateTime: ['Parameter "Date Time" is required.'],
|
||||
},
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user