chore: Convert ErrorReporting to a Service to use DI. Add some tests (no-changelog) (#11279)

packages/workflow/src/ErrorReporterProxy.ts

@@ -1,47 +0,0 @@
-import { ApplicationError, type ReportingOptions } from './errors/application.error';
-import * as Logger from './LoggerProxy';
-
-interface ErrorReporter {
-	report: (error: Error | string, options?: ReportingOptions) => void;
-}
-
-const instance: ErrorReporter = {
-	report: (error, options) => {
-		if (error instanceof Error) {
-			let e = error;
-
-			const { executionId } = options ?? {};
-			const context = executionId ? ` (execution ${executionId})` : '';
-
-			do {
-				const msg = [e.message + context, e.stack ? `\n${e.stack}\n` : ''].join('');
-				const meta = e instanceof ApplicationError ? e.extra : undefined;
-				Logger.error(msg, meta);
-				e = e.cause as Error;
-			} while (e);
-		}
-	},
-};
-
-export function init(errorReporter: ErrorReporter) {
-	instance.report = errorReporter.report;
-}
-
-const wrap = (e: unknown) => {
-	if (e instanceof Error) return e;
-	if (typeof e === 'string') return new ApplicationError(e);
-	return;
-};
-
-export const error = (e: unknown, options?: ReportingOptions) => {
-	const toReport = wrap(e);
-	if (toReport) instance.report(toReport, options);
-};
-
-export const info = (msg: string, options?: ReportingOptions) => {
-	Logger.info(msg);
-	instance.report(msg, { ...options, level: 'info' });
-};
-
-export const warn = (warning: Error | string, options?: ReportingOptions) =>
-	error(warning, { ...options, level: 'warning' });

packages/workflow/src/errors/index.ts

@@ -1,4 +1,4 @@
-export { ApplicationError } from './application.error';
+export { ApplicationError, ReportingOptions } from './application.error';
 export { ExpressionError } from './expression.error';
 export { CredentialAccessError } from './credential-access-error';
 export { ExecutionCancelledError } from './execution-cancelled.error';

packages/workflow/src/index.ts

@@ -1,5 +1,4 @@
 import * as LoggerProxy from './LoggerProxy';
-export * as ErrorReporterProxy from './ErrorReporterProxy';
 export * as ExpressionEvaluatorProxy from './ExpressionEvaluatorProxy';
 import * as NodeHelpers from './NodeHelpers';
 import * as ObservableObject from './ObservableObject';