admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Fix property existence checks on AugmentObject (#6842)

Browse Source 
Fixes https://community.n8n.io/t/code-node-returns-full-item-object-on-node-all/28823
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-08-03 12:19:30 +02:00
committed by GitHub
parent e4f041815a
commit 732416f52f
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/workflow/src/AugmentObject.ts
View File

@@ -33,7 +33,7 @@ export function augmentArray<T>(data: T[]): T[] {
return Reflect.deleteProperty(getData(), key); return Reflect.deleteProperty(getData(), key);
}, },
get(target, key: string, receiver): unknown { get(target, key: string, receiver): unknown {
const value = Reflect.get(newData !== undefined ? newData : target, key, receiver) as unknown; const value = Reflect.get(newData ?? target, key, receiver) as unknown;
const newValue = augment(value); const newValue = augment(value);
if (newValue !== value) { if (newValue !== value) {
newData = getData(); newData = getData();
@@ -54,10 +54,10 @@ export function augmentArray<T>(data: T[]): T[] {
return Object.getOwnPropertyDescriptor(data, key) ?? defaultPropertyDescriptor; return Object.getOwnPropertyDescriptor(data, key) ?? defaultPropertyDescriptor;
}, },
has(target, key) { has(target, key) {
return Reflect.has(newData !== undefined ? newData : target, key); return Reflect.has(newData ?? target, key);
}, },
ownKeys(target) { ownKeys(target) {
return Reflect.ownKeys(newData !== undefined ? newData : target); return Reflect.ownKeys(newData ?? target);
}, },
set(target, key: string, newValue: unknown) { set(target, key: string, newValue: unknown) {
// Always proxy all objects. Like that we can check in get simply if it // Always proxy all objects. Like that we can check in get simply if it
@@ -134,8 +134,7 @@ export function augmentObject<T extends object>(data: T): T {
}, },
has(target, key) { has(target, key) {
if (deletedProperties.indexOf(key) !== -1) return false; if (deletedProperties.indexOf(key) !== -1) return false;
const newKeys = Object.keys(newData); return Reflect.has(newData, key) || Reflect.has(target, key);
return Reflect.has(newKeys.length ? newData : target, key);
}, },
ownKeys(target) { ownKeys(target) {
const originalKeys = Reflect.ownKeys(target); const originalKeys = Reflect.ownKeys(target);

1
packages/workflow/test/AugmentObject.test.ts
View File

@@ -570,6 +570,7 @@ describe('AugmentObject', () => {
augmentedObject.x.z = 5; augmentedObject.x.z = 5;
expect('z' in augmentedObject.x).toBe(true); expect('z' in augmentedObject.x).toBe(true);
expect('y' in augmentedObject.x).toBe(true);
}); });
}); });
}); });