fix(editor): Maintain back button when installing community nodes (#16069)

This commit is contained in:
Dana
2025-06-06 17:40:08 +02:00
committed by GitHub
parent cb3bb915df
commit 7492944a37
2 changed files with 12 additions and 3 deletions

View File

@@ -30,6 +30,7 @@ const getAllNodeCreateElements = vi.fn(() => [
const popViewStack = vi.fn(); const popViewStack = vi.fn();
const pushViewStack = vi.fn(); const pushViewStack = vi.fn();
const updateCurrentViewStack = vi.fn();
const showError = vi.fn(); const showError = vi.fn();
@@ -114,6 +115,7 @@ vi.mock('../composables/useViewStacks', () => ({
}, },
pushViewStack, pushViewStack,
popViewStack, popViewStack,
updateCurrentViewStack,
getAllNodeCreateElements, getAllNodeCreateElements,
})), })),
})); }));
@@ -148,6 +150,7 @@ describe('CommunityNodeDetails', () => {
expect(fetchCredentialTypes).toHaveBeenCalledWith(true); expect(fetchCredentialTypes).toHaveBeenCalledWith(true);
expect(getAllNodeCreateElements).toHaveBeenCalled(); expect(getAllNodeCreateElements).toHaveBeenCalled();
expect(popViewStack).toHaveBeenCalled(); expect(popViewStack).toHaveBeenCalled();
expect(updateCurrentViewStack).toHaveBeenCalled();
expect(pushViewStack).toHaveBeenCalledWith( expect(pushViewStack).toHaveBeenCalledWith(
{ {
communityNodeDetails: { communityNodeDetails: {
@@ -184,7 +187,6 @@ describe('CommunityNodeDetails', () => {
title: 'Node details', title: 'Node details',
}, },
{ {
resetStacks: true,
transitionDirection: 'none', transitionDirection: 'none',
}, },
); );

View File

@@ -16,7 +16,13 @@ import { prepareCommunityNodeDetailsViewStack, removePreviewToken } from '../uti
import { N8nText } from '@n8n/design-system'; import { N8nText } from '@n8n/design-system';
const { activeViewStack, pushViewStack, popViewStack, getAllNodeCreateElements } = useViewStacks(); const {
activeViewStack,
pushViewStack,
popViewStack,
getAllNodeCreateElements,
updateCurrentViewStack,
} = useViewStacks();
const { communityNodeDetails } = activeViewStack; const { communityNodeDetails } = activeViewStack;
@@ -37,6 +43,8 @@ const updateViewStack = (key: string) => {
popViewStack(); popViewStack();
updateCurrentViewStack({ searchItems: nodeCreatorStore.mergedNodes });
const viewStack = prepareCommunityNodeDetailsViewStack( const viewStack = prepareCommunityNodeDetailsViewStack(
installedNode, installedNode,
getNodeIconSource(installedNode.properties), getNodeIconSource(installedNode.properties),
@@ -45,7 +53,6 @@ const updateViewStack = (key: string) => {
); );
pushViewStack(viewStack, { pushViewStack(viewStack, {
resetStacks: true,
transitionDirection: 'none', transitionDirection: 'none',
}); });
} else { } else {