fix(editor): Fix same order of buttons in run data selector (#14677)

This commit is contained in:
Mutasem Aldmour
2025-04-17 09:32:07 +02:00
committed by GitHub
parent 874402e0b3
commit 74de4037be
2 changed files with 5 additions and 11 deletions

View File

@@ -704,11 +704,11 @@ describe('NDV', () => {
ndv.getters.outputTableRow(1).find('mark').should('have.text', '<lib'); ndv.getters.outputTableRow(1).find('mark').should('have.text', '<lib');
ndv.getters.outputDisplayMode().find('label').eq(1).should('include.text', 'JSON'); ndv.getters.outputDisplayMode().find('label').eq(2).should('include.text', 'JSON');
ndv.getters ndv.getters
.outputDisplayMode() .outputDisplayMode()
.find('label') .find('label')
.eq(1) .eq(2)
.scrollIntoView() .scrollIntoView()
.should('be.visible') .should('be.visible')
.click(); .click();
@@ -722,8 +722,8 @@ describe('NDV', () => {
); );
ndv.getters.outputDataContainer().find('mark').should('have.text', '<lib'); ndv.getters.outputDataContainer().find('mark').should('have.text', '<lib');
ndv.getters.outputDisplayMode().find('label').eq(2).should('include.text', 'Schema'); ndv.getters.outputDisplayMode().find('label').eq(0).should('include.text', 'Schema');
ndv.getters.outputDisplayMode().find('label').eq(2).click({ force: true }); ndv.getters.outputDisplayMode().find('label').eq(0).click({ force: true });
ndv.getters ndv.getters
.outputDataContainer() .outputDataContainer()
.findChildByTestId('run-data-schema-item-value') .findChildByTestId('run-data-schema-item-value')

View File

@@ -251,6 +251,7 @@ const canPinData = computed(
); );
const displayModes = computed(() => { const displayModes = computed(() => {
const defaults: Array<{ label: string; value: IRunDataDisplayMode }> = [ const defaults: Array<{ label: string; value: IRunDataDisplayMode }> = [
{ label: i18n.baseText('runData.schema'), value: 'schema' },
{ label: i18n.baseText('runData.table'), value: 'table' }, { label: i18n.baseText('runData.table'), value: 'table' },
{ label: i18n.baseText('runData.json'), value: 'json' }, { label: i18n.baseText('runData.json'), value: 'json' },
]; ];
@@ -259,13 +260,6 @@ const displayModes = computed(() => {
defaults.push({ label: i18n.baseText('runData.binary'), value: 'binary' }); defaults.push({ label: i18n.baseText('runData.binary'), value: 'binary' });
} }
const schemaView = { label: i18n.baseText('runData.schema'), value: 'schema' } as const;
if (isPaneTypeInput.value) {
defaults.unshift(schemaView);
} else {
defaults.push(schemaView);
}
if ( if (
isPaneTypeOutput.value && isPaneTypeOutput.value &&
activeNode.value?.type === HTML_NODE_TYPE && activeNode.value?.type === HTML_NODE_TYPE &&