mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-19 11:01:15 +00:00
fix(n8n Form Node): Prevent XSS with video and source tags (#16329)
This commit is contained in:
81
packages/nodes-base/nodes/Form/utils/formCompletionUtils.ts
Normal file
81
packages/nodes-base/nodes/Form/utils/formCompletionUtils.ts
Normal file
@@ -0,0 +1,81 @@
|
||||
import { type Response } from 'express';
|
||||
import {
|
||||
type NodeTypeAndVersion,
|
||||
type IWebhookFunctions,
|
||||
type IWebhookResponseData,
|
||||
type IBinaryData,
|
||||
type IDataObject,
|
||||
OperationalError,
|
||||
} from 'n8n-workflow';
|
||||
|
||||
import { sanitizeCustomCss, sanitizeHtml } from './utils';
|
||||
|
||||
const getBinaryDataFromNode = (context: IWebhookFunctions, nodeName: string): IDataObject => {
|
||||
return context.evaluateExpression(`{{ $('${nodeName}').first().binary }}`) as IDataObject;
|
||||
};
|
||||
|
||||
export const binaryResponse = async (
|
||||
context: IWebhookFunctions,
|
||||
): Promise<{ data: string | Buffer; fileName: string; type: string }> => {
|
||||
const inputDataFieldName = context.getNodeParameter('inputDataFieldName', '') as string;
|
||||
const parentNodes = context.getParentNodes(context.getNode().name);
|
||||
const binaryNode = parentNodes
|
||||
.reverse()
|
||||
.find((node) => getBinaryDataFromNode(context, node?.name)?.hasOwnProperty(inputDataFieldName));
|
||||
if (!binaryNode) {
|
||||
throw new OperationalError(`No binary data with field ${inputDataFieldName} found.`);
|
||||
}
|
||||
const binaryData = getBinaryDataFromNode(context, binaryNode?.name)[
|
||||
inputDataFieldName
|
||||
] as IBinaryData;
|
||||
|
||||
return {
|
||||
// If a binaryData has an id, the following field is set:
|
||||
// N8N_DEFAULT_BINARY_DATA_MODE=filesystem
|
||||
data: binaryData.id
|
||||
? await context.helpers.binaryToBuffer(await context.helpers.getBinaryStream(binaryData.id))
|
||||
: atob(binaryData.data),
|
||||
fileName: binaryData.fileName ?? 'file',
|
||||
type: binaryData.mimeType,
|
||||
};
|
||||
};
|
||||
|
||||
export const renderFormCompletion = async (
|
||||
context: IWebhookFunctions,
|
||||
res: Response,
|
||||
trigger: NodeTypeAndVersion,
|
||||
): Promise<IWebhookResponseData> => {
|
||||
const completionTitle = context.getNodeParameter('completionTitle', '') as string;
|
||||
const completionMessage = context.getNodeParameter('completionMessage', '') as string;
|
||||
const redirectUrl = context.getNodeParameter('redirectUrl', '') as string;
|
||||
const options = context.getNodeParameter('options', {}) as {
|
||||
formTitle: string;
|
||||
customCss?: string;
|
||||
};
|
||||
const responseText = context.getNodeParameter('responseText', '') as string;
|
||||
const binary =
|
||||
context.getNodeParameter('respondWith', '') === 'returnBinary'
|
||||
? await binaryResponse(context)
|
||||
: '';
|
||||
|
||||
let title = options.formTitle;
|
||||
if (!title) {
|
||||
title = context.evaluateExpression(`{{ $('${trigger?.name}').params.formTitle }}`) as string;
|
||||
}
|
||||
const appendAttribution = context.evaluateExpression(
|
||||
`{{ $('${trigger?.name}').params.options?.appendAttribution === false ? false : true }}`,
|
||||
) as boolean;
|
||||
|
||||
res.render('form-trigger-completion', {
|
||||
title: completionTitle,
|
||||
message: completionMessage,
|
||||
formTitle: title,
|
||||
appendAttribution,
|
||||
responseText: sanitizeHtml(responseText),
|
||||
responseBinary: encodeURIComponent(JSON.stringify(binary)),
|
||||
dangerousCustomCss: sanitizeCustomCss(options.customCss),
|
||||
redirectUrl,
|
||||
});
|
||||
|
||||
return { noWebhookResponse: true };
|
||||
};
|
||||
Reference in New Issue
Block a user