fix(core): Reduce logging overhead for levels that do not output (#7479)

all current logging calls execute `callsites()` to figure out what code
tried to log. This happens even for logging methods that aren't supposed
to create any output. Under moderate load, this can take up quite a lot
of resources. This PR changes the logger to make all ignorable logging
methods a No-Op.

In a small benchmark with a simple webhook, with log-level set to
`warn`, and using `ab -c 50 -n 500
http://localhost:5678/webhook/testing`, these were the response times:

### Before

![Before](https://github.com/n8n-io/n8n/assets/196144/01680fd9-3d2a-4f7f-bb1c-5b03bd7d5bc3)

### After

![After](https://github.com/n8n-io/n8n/assets/196144/ccacb20a-48ca-455a-a8cb-098c9c0e352e)
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-10-20 18:26:33 +02:00
committed by GitHub
parent 0b42d1aa71
commit 76c04815f7
4 changed files with 22 additions and 18 deletions

View File

@@ -6,10 +6,7 @@ const { LoggerProxy } = require('n8n-workflow');
const { packageDir, writeJSON } = require('./common');
const { loadClassInIsolation } = require('../dist/ClassLoader');
LoggerProxy.init({
log: console.log.bind(console),
warn: console.warn.bind(console),
});
LoggerProxy.init(console);
const loadClass = (sourcePath) => {
try {

View File

@@ -4,10 +4,7 @@ const { LoggerProxy, NodeHelpers } = require('n8n-workflow');
const { PackageDirectoryLoader } = require('../dist/DirectoryLoader');
const { packageDir, writeJSON } = require('./common');
LoggerProxy.init({
log: console.log.bind(console),
warn: console.warn.bind(console),
});
LoggerProxy.init(console);
function findReferencedMethods(obj, refs = {}, latestName = '') {
for (const key in obj) {