admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 01:56:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482)

Browse Source 
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
This commit is contained in:
Iván Ovejero
2023-10-24 10:37:02 +02:00
committed by GitHub
parent a9fdd018f4
commit 78243edd18
5 changed files with 7 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/cli/src/databases/repositories/execution.repository.ts
View File

@@ -301,10 +301,7 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
* Permanently remove a single execution and its binary data.
*/
async hardDelete(ids: { workflowId: string; executionId: string }) {
return Promise.all([
this.binaryDataService.deleteMany([ids]),
this.delete({ id: ids.executionId }),
]);
return Promise.all([this.delete(ids.executionId), this.binaryDataService.deleteMany([ids])]);
}
async updateExistingExecution(executionId: string, execution: Partial<IExecutionResponse>) {
@@ -565,7 +562,7 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
return;
}
await this.binaryDataService.deleteMany(workflowIdsAndExecutionIds);
await this.binaryDataService.deleteMany(workflowIdsAndExecutionIds); // only in FS mode
this.logger.debug(
`Hard-deleting ${executionIds.length} executions from database (pruning cycle)`,