admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Remove binary data when deleting executions by filter (#9056)

Browse Source
This commit is contained in:
Iván Ovejero
2024-04-05 18:00:35 +02:00
committed by GitHub
parent 0c90c7c8c1
commit 7bf0f900f1
2 changed files with 37 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/cli/src/databases/repositories/execution.repository.ts
View File

@@ -407,7 +407,7 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
}
const query = this.createQueryBuilder('execution')
.select(['execution.id'])
.select(['execution.id', 'execution.workflowId'])
.andWhere('execution.workflowId IN (:...accessibleWorkflowIds)', { accessibleWorkflowIds });
if (deleteConditions.deleteBefore) {
@@ -433,12 +433,19 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
return;
}
const executionIds = executions.map(({ id }) => id);
const ids = executions.map(({ id, workflowId }) => ({
executionId: id,
workflowId,
}));
do {
// Delete in batches to avoid "SQLITE_ERROR: Expression tree is too large (maximum depth 1000)" error
const batch = executionIds.splice(0, this.hardDeletionBatchSize);
await this.delete(batch);
} while (executionIds.length > 0);
const batch = ids.splice(0, this.hardDeletionBatchSize);
await Promise.all([
this.delete(batch.map(({ executionId }) => executionId)),
this.binaryDataService.deleteMany(batch),
]);
} while (ids.length > 0);
}
async getIdsSince(date: Date) {