chore(core): Lintfix modern packages (#17046)

packages/@n8n/backend-common/src/utils/is-object-literal.ts

@@ -12,7 +12,6 @@ export function isObjectLiteral(candidate: unknown): candidate is ObjectLiteral
 		typeof candidate === 'object' &&
 		candidate !== null &&
 		!Array.isArray(candidate) &&
-		// eslint-disable-next-line @typescript-eslint/no-restricted-types
+		(Object.getPrototypeOf(candidate) as object)?.constructor?.name === 'Object'
-		(Object.getPrototypeOf(candidate) as Object)?.constructor?.name === 'Object'
 	);
 }

packages/@n8n/config/src/decorators.ts

@@ -33,7 +33,6 @@ export const Config: ClassDecorator = (ConfigClass: Class) => {
 		);
 		const classMetadata = globalMetadata.get(ConfigClass);
 		if (!classMetadata) {
-			// eslint-disable-next-line n8n-local-rules/no-plain-errors
 			throw new Error('Invalid config class: ' + ConfigClass.name);
 		}
 
@@ -106,7 +105,6 @@ export const Env =
 		const type = Reflect.getMetadata('design:type', target, key) as PropertyType;
 		const isZodSchema = schema instanceof z.ZodType;
 		if (type === Object && !isZodSchema) {
-			// eslint-disable-next-line n8n-local-rules/no-plain-errors
 			throw new Error(
 				`Invalid decorator metadata on key "${key as string}" on ${ConfigClass.name}\n Please use explicit typing on all config fields`,
 			);

packages/@n8n/db/src/migrations/common/1659888469333-AddJsonKeyPinData.ts

@@ -54,7 +54,6 @@ export class AddJsonKeyPinData1659888469333 implements IrreversibleMigration {
 			}
 
 			const newPinDataPerWorkflow = Object.keys(pinDataPerWorkflow).reduce<NewPinnedData>(
-				// eslint-disable-next-line @typescript-eslint/no-shadow
 				(newPinDataPerWorkflow, nodeName) => {
 					let pinDataPerNode = pinDataPerWorkflow[nodeName];
 

packages/@n8n/db/src/migrations/dsl/column.ts

@@ -124,7 +124,6 @@ export class Column {
 		return this;
 	}
 
-	// eslint-disable-next-line complexity
 	toOptions(driver: Driver): TableColumnOptions {
 		const {
 			name,

packages/@n8n/db/src/migrations/sqlite/1690000000002-MigrateIntegerKeysToString.ts

@@ -10,7 +10,6 @@ export class MigrateIntegerKeysToString1690000000002 implements IrreversibleMigr
 	transaction = false as const;
 
 	async up(context: MigrationContext) {
-		// eslint-disable-next-line @typescript-eslint/no-use-before-define
 		await pruneExecutionsData(context);
 
 		const { queryRunner, tablePrefix } = context;

packages/@n8n/db/src/repositories/execution.repository.ts

@@ -1001,7 +1001,6 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
 			qb.setParameter('value', exactMatch ? value : `%${value}%`);
 		}
 
-		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
 		if (annotationTags?.length || vote) {
 			// If there is a filter by one or multiple tags or by vote - we need to join the annotations table
 			qb.innerJoin('execution.annotation', 'annotation');

packages/@n8n/decorators/src/multi-main/__tests__/on-multi-main-event.test.ts

@@ -1,10 +1,12 @@
-import { Container } from '@n8n/di';
+import { Container, Service } from '@n8n/di';
-import { Service } from '@n8n/di';
 import { EventEmitter } from 'node:events';
 
 import { NonMethodError } from '../../errors';
-import { MultiMainMetadata } from '../multi-main-metadata';
+import {
-import { LEADER_TAKEOVER_EVENT_NAME, LEADER_STEPDOWN_EVENT_NAME } from '../multi-main-metadata';
+	MultiMainMetadata,
+	LEADER_TAKEOVER_EVENT_NAME,
+	LEADER_STEPDOWN_EVENT_NAME,
+} from '../multi-main-metadata';
 import { OnLeaderStepdown, OnLeaderTakeover } from '../on-multi-main-event';
 
 class MockMultiMainSetup extends EventEmitter {

packages/@n8n/decorators/src/pubsub/__tests__/on-pubsub-event.test.ts

@@ -1,5 +1,4 @@
-import { Container } from '@n8n/di';
+import { Container, Service } from '@n8n/di';
-import { Service } from '@n8n/di';
 
 import { NonMethodError } from '../../errors';
 import { OnPubSubEvent } from '../on-pubsub-event';

packages/@n8n/di/src/__tests__/circular-depedency.test.ts

@@ -1,6 +1,6 @@
+import { Container } from '../di';
 import { ServiceA } from './fixtures/service-a';
 import { ServiceB } from './fixtures/service-b';
-import { Container } from '../di';
 
 describe('DI Container', () => {
 	describe('circular dependency', () => {

packages/@n8n/imap/src/imap-simple.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import { EventEmitter } from 'events';
 import type Imap from 'imap';
 import { type ImapMessage } from 'imap';

packages/@n8n/imap/src/index.ts

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
-/* eslint-disable @typescript-eslint/no-use-before-define */
+
 import Imap from 'imap';
 
 import { ConnectionClosedError, ConnectionEndedError, ConnectionTimeoutError } from './errors';

packages/@n8n/imap/src/part-data.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import * as iconvlite from 'iconv-lite';
 import * as qp from 'quoted-printable';
 import * as utf8 from 'utf8';

packages/@n8n/task-runner/src/js-task-runner/require-resolver.ts

@@ -37,7 +37,6 @@ export function createRequireResolver({
 			throw new ExecutionError(error);
 		}
 
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		return require(request) as unknown;
 	};
 }

packages/@n8n/task-runner/src/task-runner.ts

@@ -394,7 +394,6 @@ export abstract class TaskRunner extends EventEmitter {
 		});
 	}
 
-	// eslint-disable-next-line @typescript-eslint/naming-convention
 	async executeTask(_taskParams: TaskParams, _signal: AbortSignal): Promise<TaskResultData> {
 		throw new ApplicationError('Unimplemented');
 	}