mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 10:02:05 +00:00
refactor(core): Improve community node repo code (#3767)
* 📘 Tighten `NodeRequest` * :blue: Add `AuthAgent` type * ⚡ Add constants * 📘 Namespace npm types * 🧪 Set up `createAuthAgent` * 🧪 Refactor helpers tests * 🧪 Refactor endpoints tests * ⚡ Refactor CNR helpers * ⚡ Return promises in `packageModel` * ⚡ Refactor endpoints * ✏️ Restore naming * ➕ Expose dependency `jest-mock` * 📦 Update `package-lock.json` * 📦 Update `package-lock.json` * 👕 Fix lint * 🚚 Rename namespace * 🔥 Remove outdated comment * 🐛 Fix `Promise` comparison * ⏪ Undo `ResponseHelper` change * ✏️ Document `ResponseError` * 🎨 Fix formatting
This commit is contained in:
Iván Ovejero
@@ -1,341 +1,333 @@
|
||||
import { exec } from 'child_process';
|
||||
import path from 'path';
|
||||
|
||||
import express from 'express';
|
||||
import { mocked } from 'jest-mock';
|
||||
|
||||
import * as utils from './shared/utils';
|
||||
import type { InstalledNodePayload, InstalledPackagePayload } from './shared/types';
|
||||
import type { Role } from '../../src/databases/entities/Role';
|
||||
import type { User } from '../../src/databases/entities/User';
|
||||
import * as testDb from './shared/testDb';
|
||||
|
||||
jest.mock('../../src/CommunityNodes/helpers', () => ({
|
||||
matchPackagesWithUpdates: jest.requireActual('../../src/CommunityNodes/helpers').matchPackagesWithUpdates,
|
||||
parsePackageName: jest.requireActual('../../src/CommunityNodes/helpers').parsePackageName,
|
||||
hasPackageLoadedSuccessfully: jest.fn(),
|
||||
searchInstalledPackage: jest.fn(),
|
||||
executeCommand: jest.fn(),
|
||||
checkPackageStatus: jest.fn(),
|
||||
removePackageFromMissingList: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('../../src/CommunityNodes/packageModel', () => ({
|
||||
getAllInstalledPackages: jest.requireActual('../../src/CommunityNodes/packageModel').getAllInstalledPackages,
|
||||
removePackageFromDatabase: jest.fn(),
|
||||
searchInstalledPackage: jest.fn(),
|
||||
}));
|
||||
|
||||
import { executeCommand, checkPackageStatus, hasPackageLoadedSuccessfully, removePackageFromMissingList } from '../../src/CommunityNodes/helpers';
|
||||
import { getAllInstalledPackages, searchInstalledPackage, removePackageFromDatabase } from '../../src/CommunityNodes/packageModel';
|
||||
import {
|
||||
executeCommand,
|
||||
checkNpmPackageStatus,
|
||||
hasPackageLoaded,
|
||||
removePackageFromMissingList,
|
||||
isNpmError,
|
||||
} from '../../src/CommunityNodes/helpers';
|
||||
import { findInstalledPackage, isPackageInstalled } from '../../src/CommunityNodes/packageModel';
|
||||
import { CURRENT_PACKAGE_VERSION, UPDATED_PACKAGE_VERSION } from './shared/constants';
|
||||
import { installedPackagePayload } from './shared/utils';
|
||||
import { LoadNodesAndCredentials } from '../../src/LoadNodesAndCredentials';
|
||||
import { InstalledPackages } from '../../src/databases/entities/InstalledPackages';
|
||||
|
||||
import type { Role } from '../../src/databases/entities/Role';
|
||||
import type { AuthAgent } from './shared/types';
|
||||
import type { InstalledNodes } from '../../src/databases/entities/InstalledNodes';
|
||||
|
||||
jest.mock('../../src/telemetry');
|
||||
|
||||
jest.mock('../../src/LoadNodesAndCredentials', () => ({
|
||||
LoadNodesAndCredentials: jest.fn(),
|
||||
}));
|
||||
import { LoadNodesAndCredentials } from '../../src/LoadNodesAndCredentials';
|
||||
jest.mock('../../src/CommunityNodes/helpers', () => {
|
||||
return {
|
||||
...jest.requireActual('../../src/CommunityNodes/helpers'),
|
||||
checkNpmPackageStatus: jest.fn(),
|
||||
executeCommand: jest.fn(),
|
||||
hasPackageLoaded: jest.fn(),
|
||||
isNpmError: jest.fn(),
|
||||
removePackageFromMissingList: jest.fn(),
|
||||
};
|
||||
});
|
||||
|
||||
jest.mock('../../src/CommunityNodes/packageModel', () => {
|
||||
return {
|
||||
...jest.requireActual('../../src/CommunityNodes/packageModel'),
|
||||
isPackageInstalled: jest.fn(),
|
||||
findInstalledPackage: jest.fn(),
|
||||
};
|
||||
});
|
||||
|
||||
const mockedEmptyPackage = mocked(utils.emptyPackage);
|
||||
|
||||
let app: express.Application;
|
||||
let testDbName = '';
|
||||
let globalOwnerRole: Role;
|
||||
let globalMemberRole: Role;
|
||||
let ownerShell: User;
|
||||
let authAgent: AuthAgent;
|
||||
|
||||
beforeAll(async () => {
|
||||
app = await utils.initTestServer({ endpointGroups: ['nodes'], applyAuth: true });
|
||||
const initResult = await testDb.init();
|
||||
testDbName = initResult.testDbName;
|
||||
|
||||
utils.initConfigFile();
|
||||
|
||||
globalOwnerRole = await testDb.getGlobalOwnerRole();
|
||||
globalMemberRole = await testDb.getGlobalMemberRole();
|
||||
ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
authAgent = utils.createAuthAgent(app);
|
||||
|
||||
utils.initConfigFile();
|
||||
utils.initTestLogger();
|
||||
utils.initTestTelemetry();
|
||||
});
|
||||
|
||||
beforeEach(async () => {
|
||||
await testDb.truncate(['InstalledNodes', 'InstalledPackages'], testDbName);
|
||||
// @ts-ignore
|
||||
executeCommand.mockReset();
|
||||
// @ts-ignore
|
||||
checkPackageStatus.mockReset();
|
||||
// @ts-ignore
|
||||
searchInstalledPackage.mockReset();
|
||||
// @ts-ignore
|
||||
hasPackageLoadedSuccessfully.mockReset();
|
||||
|
||||
mocked(executeCommand).mockReset();
|
||||
mocked(findInstalledPackage).mockReset();
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
await testDb.terminate(testDbName);
|
||||
});
|
||||
|
||||
test('GET /nodes should return empty list when no nodes are installed', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
/**
|
||||
* GET /nodes
|
||||
*/
|
||||
|
||||
const response = await authOwnerAgent.get('/nodes').send();
|
||||
test('GET /nodes should respond 200 if no nodes are installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data).toHaveLength(0);
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(0);
|
||||
});
|
||||
|
||||
test('GET /nodes should return list with installed package and node', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const installedPackage = await saveMockPackage(installedPackagePayload());
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage.packageName));
|
||||
test('GET /nodes should return list of one installed package and node', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authOwnerAgent.get('/nodes').send();
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data).toHaveLength(1);
|
||||
expect(response.body.data[0].installedNodes).toHaveLength(1);
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(1);
|
||||
expect(data[0].installedNodes).toHaveLength(1);
|
||||
});
|
||||
|
||||
test('GET /nodes should return list with multiple installed package and node', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const installedPackage1 = await saveMockPackage(installedPackagePayload());
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage1.packageName));
|
||||
test('GET /nodes should return list of multiple installed packages and nodes', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const installedPackage2 = await saveMockPackage(installedPackagePayload());
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage2.packageName));
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage2.packageName));
|
||||
const first = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(first.packageName));
|
||||
|
||||
const response = await authOwnerAgent.get('/nodes').send();
|
||||
const second = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data).toHaveLength(2);
|
||||
expect([...response.body.data[0].installedNodes, ...response.body.data[1].installedNodes]).toHaveLength(3);
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(2);
|
||||
|
||||
const allNodes = data.reduce(
|
||||
(acc: InstalledNodes[], cur: InstalledPackages) => acc.concat(cur.installedNodes),
|
||||
[],
|
||||
);
|
||||
|
||||
expect(allNodes).toHaveLength(3);
|
||||
});
|
||||
|
||||
test('GET /nodes should not check for updates when there are no packages installed', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
test('GET /nodes should not check for updates if no packages installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
await authOwnerAgent.get('/nodes').send();
|
||||
await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(executeCommand).toHaveBeenCalledTimes(0);
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledTimes(0);
|
||||
});
|
||||
|
||||
test('GET /nodes should check for updates when there are packages installed', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const installedPackage = await saveMockPackage(installedPackagePayload());
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage.packageName));
|
||||
test('GET /nodes should check for updates if packages installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
await authOwnerAgent.get('/nodes').send();
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
expect(executeCommand).toHaveBeenCalledWith('npm outdated --json', {"doNotHandleError": true});
|
||||
await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledWith('npm outdated --json', {
|
||||
doNotHandleError: true,
|
||||
});
|
||||
});
|
||||
|
||||
test('GET /nodes should mention updates when available', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const installedPackage = await saveMockPackage(installedPackagePayload());
|
||||
await saveMockNode(utils.installedNodePayload(installedPackage.packageName));
|
||||
test('GET /nodes should report package updates if available', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
// @ts-ignore
|
||||
executeCommand.mockImplementation(() => {
|
||||
throw getNpmOutdatedError(installedPackage.packageName);
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
mocked(executeCommand).mockImplementationOnce(() => {
|
||||
throw {
|
||||
code: 1,
|
||||
stdout: JSON.stringify({
|
||||
[packageName]: {
|
||||
current: CURRENT_PACKAGE_VERSION,
|
||||
wanted: CURRENT_PACKAGE_VERSION,
|
||||
latest: UPDATED_PACKAGE_VERSION,
|
||||
location: path.join('node_modules', packageName),
|
||||
},
|
||||
}),
|
||||
};
|
||||
});
|
||||
|
||||
const response = await authOwnerAgent.get('/nodes').send();
|
||||
expect(response.body.data[0].installedVersion).toBe(CURRENT_PACKAGE_VERSION);
|
||||
expect(response.body.data[0].updateAvailable).toBe(UPDATED_PACKAGE_VERSION);
|
||||
mocked(isNpmError).mockReturnValueOnce(true);
|
||||
|
||||
const {
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(data[0].installedVersion).toBe(CURRENT_PACKAGE_VERSION);
|
||||
expect(data[0].updateAvailable).toBe(UPDATED_PACKAGE_VERSION);
|
||||
});
|
||||
|
||||
// TEST POST ENDPOINT
|
||||
/**
|
||||
* POST /nodes
|
||||
*/
|
||||
|
||||
test('POST /nodes package name should not be empty', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const response = await authOwnerAgent.post('/nodes').send();
|
||||
test('POST /nodes should reject if package name is missing', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).post('/nodes');
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('POST /nodes should reject if package is duplicate', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(isPackageInstalled).mockResolvedValueOnce(true);
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(true);
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('already installed');
|
||||
});
|
||||
|
||||
test('POST /nodes should allow installing packages that could not be loaded', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(false);
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'OK' });
|
||||
|
||||
jest
|
||||
.spyOn(LoadNodesAndCredentials(), 'loadNpmModule')
|
||||
.mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(mocked(removePackageFromMissingList)).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test('POST /nodes should not install a banned package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'Banned' });
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('banned');
|
||||
});
|
||||
|
||||
/**
|
||||
* DELETE /nodes
|
||||
*/
|
||||
|
||||
test('DELETE /nodes should not delete if package name is empty', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).delete('/nodes');
|
||||
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('POST /nodes Should not install duplicate packages', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
// @ts-ignore
|
||||
searchInstalledPackage.mockImplementation(() => {
|
||||
return true;
|
||||
});
|
||||
// @ts-ignore
|
||||
hasPackageLoadedSuccessfully.mockImplementation(() => {
|
||||
return true;
|
||||
test('DELETE /nodes should reject if package is not installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).delete('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
const response = await authOwnerAgent.post('/nodes').send(requestBody);
|
||||
expect(response.status).toBe(400);
|
||||
expect(response.body.message).toContain('already installed');
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
});
|
||||
|
||||
test('POST /nodes Should allow installing packages that could not be loaded', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
// @ts-ignore
|
||||
searchInstalledPackage.mockImplementation(() => {
|
||||
return true;
|
||||
});
|
||||
// @ts-ignore
|
||||
hasPackageLoadedSuccessfully.mockImplementation(() => {
|
||||
return false;
|
||||
test('DELETE /nodes should uninstall package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const removeSpy = jest
|
||||
.spyOn(LoadNodesAndCredentials(), 'removeNpmModule')
|
||||
.mockImplementationOnce(jest.fn());
|
||||
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).delete('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
// @ts-ignore
|
||||
checkPackageStatus.mockImplementation(() => {
|
||||
return {status:'OK'};
|
||||
});
|
||||
|
||||
// @ts-ignore
|
||||
LoadNodesAndCredentials.mockImplementation(() => {
|
||||
return {
|
||||
loadNpmModule: () => {
|
||||
return {
|
||||
installedNodes: [],
|
||||
};
|
||||
},
|
||||
};
|
||||
});
|
||||
|
||||
const response = await authOwnerAgent.post('/nodes').send(requestBody);
|
||||
|
||||
expect(removePackageFromMissingList).toHaveBeenCalled();
|
||||
expect(response.status).toBe(200);
|
||||
expect(statusCode).toBe(200);
|
||||
expect(removeSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
test('POST /nodes package should not install banned package', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const installedPackage = installedPackagePayload();
|
||||
const requestBody = {
|
||||
name: installedPackage.packageName,
|
||||
};
|
||||
/**
|
||||
* PATCH /nodes
|
||||
*/
|
||||
|
||||
// @ts-ignore
|
||||
checkPackageStatus.mockImplementation(() => {
|
||||
return {status:'Banned'};
|
||||
});
|
||||
const response = await authOwnerAgent.post('/nodes').send(requestBody);
|
||||
expect(response.statusCode).toBe(400);
|
||||
expect(response.body.message).toContain('banned');
|
||||
});
|
||||
test('PATCH /nodes should reject if package name is empty', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
// TEST DELETE ENDPOINT
|
||||
test('DELETE /nodes package name should not be empty', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const response = await authOwnerAgent.delete('/nodes').send();
|
||||
const response = await authAgent(ownerShell).patch('/nodes');
|
||||
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('DELETE /nodes Should return error when package was not installed', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
test('PATCH /nodes reject if package is not installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authOwnerAgent.delete('/nodes').send(requestBody);
|
||||
expect(response.status).toBe(400);
|
||||
expect(response.body.message).toContain('not installed');
|
||||
});
|
||||
|
||||
// Useful test ?
|
||||
test('DELETE /nodes package should be uninstall all conditions are true', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
// @ts-ignore
|
||||
searchInstalledPackage.mockImplementation(() => {
|
||||
return {
|
||||
installedNodes: [],
|
||||
};
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
const removeNpmModuleMock = jest.fn();
|
||||
// @ts-ignore
|
||||
LoadNodesAndCredentials.mockImplementation(() => {
|
||||
return {
|
||||
removeNpmModule: removeNpmModuleMock,
|
||||
};
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
});
|
||||
|
||||
test('PATCH /nodes should update a package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const updateSpy = jest
|
||||
.spyOn(LoadNodesAndCredentials(), 'updateNpmModule')
|
||||
.mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
await authAgent(ownerShell).patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
const response = await authOwnerAgent.delete('/nodes').send(requestBody);
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(removeNpmModuleMock).toHaveBeenCalledTimes(1);
|
||||
expect(updateSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
// TEST PATCH ENDPOINT
|
||||
|
||||
test('PATCH /nodes package name should not be empty', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const response = await authOwnerAgent.patch('/nodes').send();
|
||||
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('PATCH /nodes Should return error when package was not installed', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
|
||||
const response = await authOwnerAgent.patch('/nodes').send(requestBody);
|
||||
expect(response.status).toBe(400);
|
||||
expect(response.body.message).toContain('not installed');
|
||||
});
|
||||
|
||||
test('PATCH /nodes package should be updated if all conditions are true', async () => {
|
||||
const authOwnerAgent = utils.createAgent(app, { auth: true, user: ownerShell });
|
||||
const requestBody = {
|
||||
name: installedPackagePayload().packageName,
|
||||
};
|
||||
// @ts-ignore
|
||||
searchInstalledPackage.mockImplementation(() => {
|
||||
return {
|
||||
installedNodes: [],
|
||||
};
|
||||
});
|
||||
|
||||
const updatedNpmModuleMock = jest.fn(() => ({
|
||||
installedNodes: [],
|
||||
}));
|
||||
|
||||
// @ts-ignore
|
||||
LoadNodesAndCredentials.mockImplementation(() => {
|
||||
return {
|
||||
updateNpmModule: updatedNpmModuleMock,
|
||||
};
|
||||
});
|
||||
|
||||
const response = await authOwnerAgent.patch('/nodes').send(requestBody);
|
||||
expect(updatedNpmModuleMock).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
async function saveMockPackage(payload: InstalledPackagePayload) {
|
||||
return await testDb.saveInstalledPackage(payload);
|
||||
}
|
||||
|
||||
async function saveMockNode(payload: InstalledNodePayload) {
|
||||
return await testDb.saveInstalledNode(payload);
|
||||
}
|
||||
|
||||
function getNpmOutdatedError(packageName: string) {
|
||||
const errorOutput = new Error('Something went wrong');
|
||||
// @ts-ignore
|
||||
errorOutput.code = 1;
|
||||
// @ts-ignore
|
||||
errorOutput.stdout = '{' +
|
||||
`"${packageName}": {` +
|
||||
`"current": "${CURRENT_PACKAGE_VERSION}",` +
|
||||
`"wanted": "${CURRENT_PACKAGE_VERSION}",` +
|
||||
`"latest": "${UPDATED_PACKAGE_VERSION}",` +
|
||||
`"location": "node_modules/${packageName}"` +
|
||||
'}' +
|
||||
'}';
|
||||
|
||||
return errorOutput;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user