refactor: Migrate NodeConnectionType to const object type (no-changelog) (#14078)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Alex Grozav
2025-03-21 14:01:26 +02:00
committed by GitHub
parent 7e8179b848
commit 8215e0b59f
703 changed files with 3104 additions and 3018 deletions

View File

@@ -1,5 +1,6 @@
import {
NodeConnectionType,
NodeConnectionTypes,
type NodeConnectionType,
type INodeIssues,
type INode,
type INodeParameters,
@@ -3549,9 +3550,9 @@ describe('NodeHelpers', () => {
[false, null],
[false, { outputs: '={{random_expression}}' }],
[false, { outputs: [] }],
[false, { outputs: [NodeConnectionType.Main] }],
[true, { outputs: [NodeConnectionType.AiAgent] }],
[true, { outputs: [NodeConnectionType.Main, NodeConnectionType.AiAgent] }],
[false, { outputs: [NodeConnectionTypes.Main] }],
[true, { outputs: [NodeConnectionTypes.AiAgent] }],
[true, { outputs: [NodeConnectionTypes.Main, NodeConnectionTypes.AiAgent] }],
];
test.each(tests)('should return %p for %o', (expected, nodeType) => {
expect(isSubNodeType(nodeType)).toBe(expected);
@@ -4267,7 +4268,7 @@ describe('NodeHelpers', () => {
version: 1,
defaults: {},
inputs: [],
outputs: [NodeConnectionType.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: true,
@@ -4282,7 +4283,7 @@ describe('NodeHelpers', () => {
version: 1,
defaults: {},
inputs: [],
outputs: [NodeConnectionType.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: true,
@@ -4296,8 +4297,8 @@ describe('NodeHelpers', () => {
description: 'Regular node description',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.Main],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: false,
@@ -4311,8 +4312,8 @@ describe('NodeHelpers', () => {
description: 'Empty group node description',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.Main],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: false,
@@ -4327,8 +4328,8 @@ describe('NodeHelpers', () => {
description: 'Almost trigger node description',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.Main],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: false,
@@ -4346,7 +4347,7 @@ describe('NodeHelpers', () => {
describe('isExecutable', () => {
const workflowMock = {
expression: {
getSimpleParameterValue: jest.fn().mockReturnValue([NodeConnectionType.Main]),
getSimpleParameterValue: jest.fn().mockReturnValue([NodeConnectionTypes.Main]),
},
} as unknown as Workflow;
@@ -4375,7 +4376,7 @@ describe('NodeHelpers', () => {
version: 1,
defaults: {},
inputs: [],
outputs: [NodeConnectionType.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: true,
@@ -4397,8 +4398,8 @@ describe('NodeHelpers', () => {
description: 'Node with Main output',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.Main],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.Main],
properties: [],
},
expected: true,
@@ -4420,8 +4421,8 @@ describe('NodeHelpers', () => {
description: 'Node without Main output and not a trigger',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.AiAgent],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.AiAgent],
properties: [],
},
expected: false,
@@ -4443,8 +4444,8 @@ describe('NodeHelpers', () => {
description: 'Node with multiple output types including Main',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
outputs: [NodeConnectionType.Main, NodeConnectionType.AiAgent],
inputs: [NodeConnectionTypes.Main],
outputs: [NodeConnectionTypes.Main, NodeConnectionTypes.AiAgent],
properties: [],
},
expected: true,
@@ -4467,7 +4468,7 @@ describe('NodeHelpers', () => {
version: 1,
defaults: {},
inputs: [],
outputs: [NodeConnectionType.AiTool], // Only AiTool output, no Main
outputs: [NodeConnectionTypes.AiTool], // Only AiTool output, no Main
properties: [],
},
expected: false,
@@ -4489,12 +4490,12 @@ describe('NodeHelpers', () => {
description: 'Node with dynamic outputs that resolve to only AiTool',
version: 1,
defaults: {},
inputs: [NodeConnectionType.Main],
inputs: [NodeConnectionTypes.Main],
outputs: '={{["ai_tool"]}}', // Dynamic expression that resolves to AiTool only
properties: [],
},
expected: false,
mockReturnValue: [NodeConnectionType.AiTool],
mockReturnValue: [NodeConnectionTypes.AiTool],
},
];