admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Enable running task runners externally (no-changelog) (#11319)

Browse Source
This commit is contained in:
Tomi Turtiainen
2024-10-22 16:23:59 +03:00
committed by GitHub
parent 216b119350
commit 8404282046
12 changed files with 99 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/cli/test/integration/runners/task-runner-process.test.ts
View File

@@ -1,4 +1,4 @@
import { GlobalConfig } from '@n8n/config';
import { TaskRunnersConfig } from '@n8n/config';
import Container from 'typedi';
import { TaskRunnerService } from '@/runners/runner-ws-server';
@@ -9,9 +9,11 @@ import { retryUntil } from '@test-integration/retry-until';
describe('TaskRunnerProcess', () => {
const authToken = 'token';
const globalConfig = Container.get(GlobalConfig);
globalConfig.taskRunners.authToken = authToken;
globalConfig.taskRunners.port = 0; // Use any port
const runnerConfig = Container.get(TaskRunnersConfig);
runnerConfig.disabled = false;
runnerConfig.mode = 'internal_childprocess';
runnerConfig.authToken = authToken;
runnerConfig.port = 0; // Use any port
const taskRunnerServer = Container.get(TaskRunnerServer);
const runnerProcess = Container.get(TaskRunnerProcess);
@@ -26,7 +28,7 @@ describe('TaskRunnerProcess', () => {
beforeAll(async () => {
await taskRunnerServer.start();
// Set the port to the actually used port
globalConfig.taskRunners.port = taskRunnerServer.port;
runnerConfig.port = taskRunnerServer.port;
});
afterAll(async () => {
@@ -100,7 +102,7 @@ describe('TaskRunnerProcess', () => {
});
it('should launch runner directly if not using a launcher', async () => {
globalConfig.taskRunners.useLauncher = false;
runnerConfig.mode = 'internal_childprocess';
await runnerProcess.start();
@@ -109,18 +111,18 @@ describe('TaskRunnerProcess', () => {
});
it('should use a launcher if configured', async () => {
globalConfig.taskRunners.useLauncher = true;
globalConfig.taskRunners.launcherPath = 'node';
runnerConfig.mode = 'internal_launcher';
runnerConfig.launcherPath = 'node';
await runnerProcess.start();
expect(startLauncherSpy).toBeCalledTimes(1);
expect(startNodeSpy).toBeCalledTimes(0);
globalConfig.taskRunners.useLauncher = false;
runnerConfig.mode = 'internal_childprocess';
});
it('should kill the process directly if not using a launcher', async () => {
globalConfig.taskRunners.useLauncher = false;
runnerConfig.mode = 'internal_childprocess';
await runnerProcess.start();
await runnerProcess.stop();
@@ -130,14 +132,14 @@ describe('TaskRunnerProcess', () => {
});
it('should kill the process using a launcher if configured', async () => {
globalConfig.taskRunners.useLauncher = true;
globalConfig.taskRunners.launcherPath = 'node';
runnerConfig.mode = 'internal_launcher';
runnerConfig.launcherPath = 'node';
await runnerProcess.start();
await runnerProcess.stop();
expect(killLauncherSpy).toBeCalledTimes(1);
expect(killNodeSpy).toBeCalledTimes(0);
globalConfig.taskRunners.useLauncher = false;
runnerConfig.mode = 'internal_childprocess';
});
});