fix(core): Ensure sentry releases follow semver (no-changelog) (#13907)

This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2025-03-14 17:48:34 +01:00
committed by GitHub
parent eec325127c
commit 86b791167a
4 changed files with 17 additions and 21 deletions

View File

@@ -160,7 +160,7 @@ jobs:
continue-on-error: true continue-on-error: true
with: with:
projects: ${{ secrets.SENTRY_FRONTEND_PROJECT }} projects: ${{ secrets.SENTRY_FRONTEND_PROJECT }}
version: ${{ needs.publish-to-npm.outputs.release }} version: n8n@${{ needs.publish-to-npm.outputs.release }}
sourcemaps: packages/frontend/editor-ui/dist sourcemaps: packages/frontend/editor-ui/dist
- name: Create a backend release - name: Create a backend release
@@ -168,7 +168,7 @@ jobs:
continue-on-error: true continue-on-error: true
with: with:
projects: ${{ secrets.SENTRY_BACKEND_PROJECT }} projects: ${{ secrets.SENTRY_BACKEND_PROJECT }}
version: ${{ needs.publish-to-npm.outputs.release }} version: n8n@${{ needs.publish-to-npm.outputs.release }}
sourcemaps: packages/cli/dist packages/core/dist packages/nodes-base/dist packages/@n8n/n8n-nodes-langchain/dist sourcemaps: packages/cli/dist packages/core/dist packages/nodes-base/dist packages/@n8n/n8n-nodes-langchain/dist
- name: Create a task runner release - name: Create a task runner release
@@ -176,7 +176,7 @@ jobs:
continue-on-error: true continue-on-error: true
with: with:
projects: ${{ secrets.SENTRY_TASK_RUNNER_PROJECT }} projects: ${{ secrets.SENTRY_TASK_RUNNER_PROJECT }}
version: ${{ needs.publish-to-npm.outputs.release }} version: n8n@${{ needs.publish-to-npm.outputs.release }}
sourcemaps: packages/core/dist packages/workflow/dist packages/@n8n/task-runner/dist sourcemaps: packages/core/dist packages/workflow/dist packages/@n8n/task-runner/dist
trigger-release-note: trigger-release-note:

View File

@@ -5,6 +5,12 @@ import type { ErrorReporter } from 'n8n-core';
import { TaskRunnerSentry } from '../task-runner-sentry'; import { TaskRunnerSentry } from '../task-runner-sentry';
describe('TaskRunnerSentry', () => { describe('TaskRunnerSentry', () => {
const commonConfig = {
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
};
afterEach(() => { afterEach(() => {
jest.resetAllMocks(); jest.resetAllMocks();
}); });
@@ -12,10 +18,8 @@ describe('TaskRunnerSentry', () => {
describe('filterOutUserCodeErrors', () => { describe('filterOutUserCodeErrors', () => {
const sentry = new TaskRunnerSentry( const sentry = new TaskRunnerSentry(
{ {
...commonConfig,
dsn: 'https://sentry.io/123', dsn: 'https://sentry.io/123',
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
}, },
mock(), mock(),
); );
@@ -103,10 +107,8 @@ describe('TaskRunnerSentry', () => {
it('should not configure sentry if dsn is not set', async () => { it('should not configure sentry if dsn is not set', async () => {
const sentry = new TaskRunnerSentry( const sentry = new TaskRunnerSentry(
{ {
...commonConfig,
dsn: '', dsn: '',
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
}, },
mockErrorReporter, mockErrorReporter,
); );
@@ -119,10 +121,8 @@ describe('TaskRunnerSentry', () => {
it('should configure sentry if dsn is set', async () => { it('should configure sentry if dsn is set', async () => {
const sentry = new TaskRunnerSentry( const sentry = new TaskRunnerSentry(
{ {
...commonConfig,
dsn: 'https://sentry.io/123', dsn: 'https://sentry.io/123',
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
}, },
mockErrorReporter, mockErrorReporter,
); );
@@ -132,7 +132,7 @@ describe('TaskRunnerSentry', () => {
expect(mockErrorReporter.init).toHaveBeenCalledWith({ expect(mockErrorReporter.init).toHaveBeenCalledWith({
dsn: 'https://sentry.io/123', dsn: 'https://sentry.io/123',
beforeSendFilter: sentry.filterOutUserCodeErrors, beforeSendFilter: sentry.filterOutUserCodeErrors,
release: '1.0.0', release: 'n8n@1.0.0',
environment: 'local', environment: 'local',
serverName: 'test', serverName: 'test',
serverType: 'task_runner', serverType: 'task_runner',
@@ -146,10 +146,8 @@ describe('TaskRunnerSentry', () => {
it('should not shutdown sentry if dsn is not set', async () => { it('should not shutdown sentry if dsn is not set', async () => {
const sentry = new TaskRunnerSentry( const sentry = new TaskRunnerSentry(
{ {
...commonConfig,
dsn: '', dsn: '',
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
}, },
mockErrorReporter, mockErrorReporter,
); );
@@ -162,10 +160,8 @@ describe('TaskRunnerSentry', () => {
it('should shutdown sentry if dsn is set', async () => { it('should shutdown sentry if dsn is set', async () => {
const sentry = new TaskRunnerSentry( const sentry = new TaskRunnerSentry(
{ {
...commonConfig,
dsn: 'https://sentry.io/123', dsn: 'https://sentry.io/123',
n8nVersion: '1.0.0',
environment: 'local',
deploymentName: 'test',
}, },
mockErrorReporter, mockErrorReporter,
); );

View File

@@ -22,7 +22,7 @@ export class TaskRunnerSentry {
await this.errorReporter.init({ await this.errorReporter.init({
serverType: 'task_runner', serverType: 'task_runner',
dsn, dsn,
release: n8nVersion, release: `n8n@${n8nVersion}`,
environment, environment,
serverName: deploymentName, serverName: deploymentName,
beforeSendFilter: this.filterOutUserCodeErrors, beforeSendFilter: this.filterOutUserCodeErrors,

View File

@@ -74,7 +74,7 @@ export abstract class BaseCommand extends Command {
serverType: this.instanceSettings.instanceType, serverType: this.instanceSettings.instanceType,
dsn: backendDsn, dsn: backendDsn,
environment, environment,
release: N8N_VERSION, release: `n8n@${N8N_VERSION}`,
serverName: deploymentName, serverName: deploymentName,
releaseDate: N8N_RELEASE_DATE, releaseDate: N8N_RELEASE_DATE,
}); });