refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -109,6 +109,7 @@ export class ActiveCampaign implements INodeType {
description: INodeTypeDescription = {
displayName: 'ActiveCampaign',
name: 'activeCampaign',
// eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg
icon: 'file:activeCampaign.png',
group: ['transform'],
version: 1,

View File

@@ -21,6 +21,7 @@ export class ActiveCampaignTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'ActiveCampaign Trigger',
name: 'activeCampaignTrigger',
// eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg
icon: 'file:activeCampaign.png',
group: ['trigger'],
version: 1,
@@ -46,7 +47,7 @@ export class ActiveCampaignTrigger implements INodeType {
],
properties: [
{
displayName: 'Events',
displayName: 'Event Names or IDs',
name: 'events',
type: 'multiOptions',
typeOptions: {

View File

@@ -58,6 +58,7 @@ export const contactFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
required: true,
displayOptions: {
@@ -87,7 +88,7 @@ export const contactFields: INodeProperties[] = [
},
},
default: false,
description: 'Update user if it exists already. If not set and user exists it will error instead.',
description: 'Whether to update user if it exists already. If not set and user exists it will error instead.',
},
{
displayName: 'Additional Fields',
@@ -245,6 +246,7 @@ export const contactFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'Email of the contact',
},
@@ -348,6 +350,7 @@ export const contactFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'Email address of the contact you want to get',
},

View File

@@ -39,6 +39,7 @@ export const contactTagFields: INodeProperties[] = [
displayName: 'Tag Name or ID',
name: 'tagId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTags',
},

View File

@@ -94,6 +94,7 @@ export const ecomCustomerFields: INodeProperties[] = [
displayName: 'Customer Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
required: true,
displayOptions: {
@@ -130,7 +131,7 @@ export const ecomCustomerFields: INodeProperties[] = [
name: 'acceptsMarketing',
type: 'boolean',
default: false,
description: 'Indication of whether customer has opt-ed in to marketing communications',
description: 'Whether customer has opt-ed in to marketing communications',
},
],
},
@@ -192,6 +193,7 @@ export const ecomCustomerFields: INodeProperties[] = [
displayName: 'Customer Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'The email address of the customer',
},
@@ -200,7 +202,7 @@ export const ecomCustomerFields: INodeProperties[] = [
name: 'acceptsMarketing',
type: 'boolean',
default: false,
description: 'Indication of whether customer has opt-ed in to marketing communications',
description: 'Whether customer has opt-ed in to marketing communications',
},
],
},

View File

@@ -114,6 +114,7 @@ export const ecomOrderFields: INodeProperties[] = [
displayName: 'Customer Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
required: true,
displayOptions: {
@@ -457,6 +458,7 @@ export const ecomOrderFields: INodeProperties[] = [
displayName: 'Customer Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'The email address of the customer who placed the order',
},