refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -34,6 +34,7 @@ export class CiscoWebex implements INodeType {
description: INodeTypeDescription = {
displayName: 'Webex by Cisco',
name: 'ciscoWebex',
// eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg
icon: 'file:ciscoWebex.png',
group: ['transform'],
version: 1,

View File

@@ -27,6 +27,7 @@ export class CiscoWebexTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'Webex by Cisco Trigger',
name: 'ciscoWebexTrigger',
// eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg
icon: 'file:ciscoWebex.png',
group: ['trigger'],
version: 1,
@@ -107,6 +108,7 @@ export class CiscoWebexTrigger implements INodeType {
},
},
default: true,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'By default the response only contain a reference to the data the user inputed. If this option gets activated, it will resolve the data automatically.',
},
{
@@ -132,7 +134,7 @@ export class CiscoWebexTrigger implements INodeType {
},
},
default: false,
description: 'Limit to messages which contain file content attachments',
description: 'Whether to limit to messages which contain file content attachments',
},
{
displayName: 'Is Locked',
@@ -150,7 +152,7 @@ export class CiscoWebexTrigger implements INodeType {
},
},
default: false,
description: 'Limit to rooms that are locked',
description: 'Whether to limit to rooms that are locked',
},
{
displayName: 'Is Moderator',
@@ -169,7 +171,7 @@ export class CiscoWebexTrigger implements INodeType {
},
},
default: false,
description: 'Limit to moderators of a room',
description: 'Whether to limit to moderators of a room',
},
{
displayName: 'Mentioned People',

View File

@@ -315,7 +315,7 @@ export function getTextBlockProperties(): INodeProperties[] {
},
},
default: false,
description: 'Displays text slightly toned down to appear less prominent',
description: 'Whether to display text slightly toned down to appear less prominent',
},
{
displayName: 'Max Lines',
@@ -407,7 +407,7 @@ export function getTextBlockProperties(): INodeProperties[] {
},
},
default: true,
description: 'If true, allow text to wrap. Otherwise, text is clipped.',
description: 'Whether to allow text to wrap. Otherwise, text is clipped.',
},
{
displayName: 'Height',
@@ -445,7 +445,7 @@ export function getTextBlockProperties(): INodeProperties[] {
],
},
},
description: 'When true, draw a separating line at the top of the element',
description: 'Whether to draw a separating line at the top of the element',
},
{
displayName: 'Spacing',
@@ -517,7 +517,7 @@ export function getTextBlockProperties(): INodeProperties[] {
},
},
default: true,
description: 'If false, this item will be removed from the visual trees',
description: 'Whether this item will be removed from the visual trees',
},
];
}
@@ -551,7 +551,7 @@ export function getInputTextProperties(): INodeProperties[] {
},
},
default: false,
description: 'If true, allow multiple lines of input',
description: 'Whether to allow multiple lines of input',
},
{
displayName: 'Max Length',

View File

@@ -211,6 +211,7 @@ export const meetingFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
required: true,
default: '',
description: 'Email address of meeting invitee',
@@ -276,6 +277,7 @@ export const meetingFields: INodeProperties[] = [
displayName: 'Required Registration Info',
name: 'requireRegistrationInfo',
type: 'multiOptions',
// eslint-disable-next-line n8n-nodes-base/node-param-multi-options-type-unsorted-items
options: [
{
name: 'Require First Name',
@@ -564,7 +566,7 @@ export const meetingFields: INodeProperties[] = [
name: 'current',
type: 'boolean',
default: true,
description: 'For meeting series, whether to return just the current meeting or all meetings',
description: 'Whether to return just the current meeting or all meetings',
},
{
displayName: 'Meeting Number',
@@ -798,6 +800,7 @@ export const meetingFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
required: true,
default: '',
description: 'Email address of meeting invitee',
@@ -870,6 +873,7 @@ export const meetingFields: INodeProperties[] = [
displayName: 'Required Registration Info',
name: 'requireRegistrationInfo',
type: 'multiOptions',
// eslint-disable-next-line n8n-nodes-base/node-param-multi-options-type-unsorted-items
options: [
{
name: 'Require First Name',

View File

@@ -80,6 +80,7 @@ export const messageFields: INodeProperties[] = [
displayName: 'Room Name or ID',
name: 'roomId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getRooms',
},