refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -85,6 +85,10 @@ export class Github implements INodeType {
name: 'Issue',
value: 'issue',
},
{
name: 'Organization',
value: 'organization',
},
{
name: 'Release',
value: 'release',
@@ -101,10 +105,6 @@ export class Github implements INodeType {
name: 'User',
value: 'user',
},
{
name: 'Organization',
value: 'organization',
},
],
default: 'issue',
},
@@ -449,7 +449,7 @@ export class Github implements INodeType {
resource: ['file'],
},
},
description: 'If the data to upload should be taken from binary field',
description: 'Whether the data to upload should be taken from binary field',
},
{
displayName: 'File Content',
@@ -525,6 +525,7 @@ export class Github implements INodeType {
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'The email of the author of the commit',
},
@@ -559,6 +560,7 @@ export class Github implements INodeType {
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
description: 'The email of the committer of the commit',
},
@@ -582,7 +584,7 @@ export class Github implements INodeType {
},
},
description:
'If set it will set the data of the file as binary property instead of returning the raw API response',
'Whether to set the data of the file as binary property instead of returning the raw API response',
},
{
displayName: 'Binary Property',
@@ -989,7 +991,7 @@ export class Github implements INodeType {
type: 'boolean',
default: false,
description:
'Set "true" to create a draft (unpublished) release, "false" to create a published one',
'Whether to create a draft (unpublished) release, "false" to create a published one',
},
{
displayName: 'Prerelease',
@@ -997,7 +999,7 @@ export class Github implements INodeType {
type: 'boolean',
default: false,
description:
'If set to "true" it will point out that the release is non-production ready',
'Whether to point out that the release is non-production ready',
},
{
displayName: 'Target Commitish',
@@ -1061,7 +1063,7 @@ export class Github implements INodeType {
type: 'boolean',
default: false,
description:
'Set "true" to create a draft (unpublished) release, "false" to create a published one',
'Whether to create a draft (unpublished) release, "false" to create a published one',
},
{
displayName: 'Name',
@@ -1076,7 +1078,7 @@ export class Github implements INodeType {
type: 'boolean',
default: false,
description:
'If set to "true" it will point out that the release is non-production ready',
'Whether to point out that the release is non-production ready',
},
{
displayName: 'Tag Name',
@@ -1538,6 +1540,7 @@ export class Github implements INodeType {
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
default: '',
required: true,
displayOptions: {

View File

@@ -218,21 +218,26 @@ export class GithubTrigger implements INodeType {
value: 'milestone',
description: 'Triggered when a milestone is created, closed, opened, edited, or deleted',
},
{
name: 'Organization',
value: 'organization',
description: 'Triggered when an organization is deleted and renamed, and when a user is added, removed, or invited to an organization. Organization hooks only.',
},
{
name: 'Org Block',
value: 'org_block',
description: 'Triggered when an organization blocks or unblocks a user. Organization hooks only.',
},
{
name: 'Organization',
value: 'organization',
description: 'Triggered when an organization is deleted and renamed, and when a user is added, removed, or invited to an organization. Organization hooks only.',
},
{
name: 'Page Build',
value: 'page_build',
description: 'Triggered on push to a GitHub Pages enabled branch (gh-pages for project pages, master for user and organization pages)',
},
{
name: 'Project',
value: 'project',
description: 'Triggered when a project is created, updated, closed, reopened, or deleted',
},
{
name: 'Project Card',
value: 'project_card',
@@ -243,11 +248,6 @@ export class GithubTrigger implements INodeType {
value: 'project_column',
description: 'Triggered when a project column is created, updated, moved, or deleted',
},
{
name: 'Project',
value: 'project',
description: 'Triggered when a project is created, updated, closed, reopened, or deleted',
},
{
name: 'Public',
value: 'public',
@@ -263,7 +263,6 @@ export class GithubTrigger implements INodeType {
value: 'pull_request_review',
description: 'Triggered when a pull request review is submitted into a non-pending state, the body is edited, or the review is dismissed',
},
{
name: 'Pull Request Review Comment',
value: 'pull_request_review_comment',