refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -1108,6 +1108,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getDealLabels',
},
@@ -1393,6 +1394,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getDealLabels',
},
@@ -1861,7 +1863,7 @@ export class Pipedrive implements INodeType {
},
},
default: false,
description: 'When enabled, only full exact matches against the given term are returned. It is not case sensitive.',
description: 'Whether only full exact matches against the given term are returned. It is not case sensitive.',
},
{
displayName: 'Return All',
@@ -2271,14 +2273,14 @@ export class Pipedrive implements INodeType {
description: 'Date when the leads deal is expected to be closed, in ISO-8601 format',
},
{
displayName: 'Label IDs',
displayName: 'Label Names or IDs',
name: 'label_ids',
type: 'multiOptions',
typeOptions: {
loadOptionsMethod: 'getLeadLabels',
},
default: [],
description: 'ID of the labels to attach to the lead to create',
description: 'ID of the labels to attach to the lead to create. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Organization ID',
@@ -2449,14 +2451,14 @@ export class Pipedrive implements INodeType {
description: 'ID of the user who will own the lead to update. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Label IDs',
displayName: 'Label Names or IDs',
name: 'label_ids',
type: 'multiOptions',
typeOptions: {
loadOptionsMethod: 'getLeadLabels',
},
default: [],
description: 'ID of the labels to attach to the lead to update',
description: 'ID of the labels to attach to the lead to update. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Person Name or ID',
@@ -2788,6 +2790,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getOrganizationLabels',
},
@@ -2900,7 +2903,7 @@ export class Pipedrive implements INodeType {
name: 'exactMatch',
type: 'boolean',
default: false,
description: 'When enabled, only full exact matches against the given term are returned. It is not case sensitive.',
description: 'Whether only full exact matches against the given term are returned. It is not case sensitive.',
},
{
displayName: 'Fields',
@@ -2932,7 +2935,7 @@ export class Pipedrive implements INodeType {
name: 'rawData',
type: 'boolean',
default: false,
description: 'Returns the data exactly in the way it got received from the API',
description: 'Whether to return the data exactly in the way it got received from the API',
},
],
},
@@ -3011,6 +3014,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getOrganizationLabels',
},
@@ -3134,6 +3138,7 @@ export class Pipedrive implements INodeType {
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
typeOptions: {
multipleValues: true,
},
@@ -3144,6 +3149,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getPersonLabels',
},
@@ -3347,6 +3353,7 @@ export class Pipedrive implements INodeType {
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
typeOptions: {
multipleValues: true,
},
@@ -3357,6 +3364,7 @@ export class Pipedrive implements INodeType {
displayName: 'Label Name or ID',
name: 'label',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getPersonLabels',
},
@@ -3470,6 +3478,7 @@ export class Pipedrive implements INodeType {
},
},
default: false,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'By default do custom properties get returned only as ID instead of their actual name. Also option fields contain only the ID instead of their actual value. If this option gets set they get automatically resolved.',
},
{
@@ -3491,6 +3500,7 @@ export class Pipedrive implements INodeType {
},
},
default: false,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'By default do custom properties have to be set as ID instead of their actual name. Also option fields have to be set as ID instead of their actual value. If this option gets set they get automatically encoded.',
},
{
@@ -3753,7 +3763,7 @@ export class Pipedrive implements INodeType {
name: 'exactMatch',
type: 'boolean',
default: false,
description: 'When enabled, only full exact matches against the given term are returned. It is not case sensitive.',
description: 'Whether only full exact matches against the given term are returned. It is not case sensitive.',
},
{
displayName: 'Fields',
@@ -3781,7 +3791,7 @@ export class Pipedrive implements INodeType {
name: 'rawData',
type: 'boolean',
default: false,
description: 'Returns the data exactly in the way it got received from the API',
description: 'Whether to return the data exactly in the way it got received from the API',
},
],
},
@@ -3892,14 +3902,14 @@ export class Pipedrive implements INodeType {
description: 'Use the Activity due date where you wish to begin fetching Activities from. Insert due date in YYYY-MM-DD format.',
},
{
displayName: 'Type',
displayName: 'Type Names or IDs',
name: 'type',
type: 'multiOptions',
typeOptions: {
loadOptionsMethod: 'getActivityTypes',
},
default: [],
description: 'Type of the Activity',
description: 'Type of the Activity. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'User Name or ID',