refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -148,7 +148,7 @@ export const campaignFields: INodeProperties[] = [
},
},
default: false,
description: 'Set to true if you want to send the campaign as well and not just create a draft. Default is false.',
description: 'Whether to send the campaign as well and not just create a draft. Default is false.',
},
{
displayName: 'Brand ID',
@@ -234,14 +234,14 @@ export const campaignFields: INodeProperties[] = [
name: 'trackClicks',
type: 'boolean',
default: true,
description: 'Set to false if you want to disable clicks tracking. Default is true.',
description: 'Whether to disable clicks tracking. Default is true.',
},
{
displayName: 'Track Opens',
name: 'trackOpens',
type: 'boolean',
default: true,
description: 'Set to false if you want to disable opens tracking. Default is true.',
description: 'Whether to disable opens tracking. Default is true.',
},
],
},

View File

@@ -29,6 +29,7 @@ export class Sendy implements INodeType {
description: INodeTypeDescription = {
displayName: 'Sendy',
name: 'sendy',
// eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg
icon: 'file:sendy.png',
group: ['input'],
version: 1,

View File

@@ -55,6 +55,7 @@ export const subscriberFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
displayOptions: {
show: {
resource: [
@@ -114,13 +115,14 @@ export const subscriberFields: INodeProperties[] = [
name: 'gdpr',
type: 'boolean',
default: false,
description: 'If you\'re signing up EU users in a GDPR compliant manner, set this to "true"',
description: 'Whether you\'re signing up EU users in a GDPR compliant manner',
},
{
displayName: 'Honeypot',
name: 'hp',
type: 'boolean',
default: false,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'Include this \'honeypot\' field to prevent spambots from signing up via this API call. When spambots fills in this field, this API call will exit, preventing them from signing up fake addresses to your form. This parameter is only supported in Sendy 3.0 onwards.',
},
{
@@ -149,6 +151,7 @@ export const subscriberFields: INodeProperties[] = [
name: 'silent',
type: 'boolean',
default: false,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'Set to "true" if your list is \'Double opt-in\' but you want to bypass that and signup the user to the list as \'Single Opt-in instead\' (optional)',
},
],
@@ -180,6 +183,7 @@ export const subscriberFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
displayOptions: {
show: {
resource: [
@@ -217,6 +221,7 @@ export const subscriberFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
displayOptions: {
show: {
resource: [
@@ -254,6 +259,7 @@ export const subscriberFields: INodeProperties[] = [
displayName: 'Email',
name: 'email',
type: 'string',
placeholder: 'name@email.com',
displayOptions: {
show: {
resource: [