feat(Data Table Node): Add bulk insert mode (no-changelog) (#19294)

This commit is contained in:
Charlie Kolb
2025-09-09 14:01:40 +02:00
committed by GitHub
parent a910604822
commit 897c69c70d
14 changed files with 383 additions and 109 deletions

View File

@@ -18,26 +18,63 @@ const displayOptions: IDisplayOptions = {
},
};
export const description: INodeProperties[] = [makeAddRow(FIELD, displayOptions)];
export const description: INodeProperties[] = [
makeAddRow(FIELD, displayOptions),
{
displayName: 'Options',
name: 'options',
type: 'collection',
placeholder: 'Add Option',
default: {},
options: [
{
displayName: 'Optimize Bulk',
name: 'optimizeBulk',
type: 'boolean',
default: false,
noDataExpression: true, // bulk inserts don't support expressions so this is a bit paradoxical
description: 'Whether to improve bulk insert performance 5x by not returning inserted data',
},
],
displayOptions,
},
];
export async function execute(
this: IExecuteFunctions,
index: number,
): Promise<INodeExecutionData[]> {
const optimizeBulkEnabled = this.getNodeParameter('options.optimizeBulk', index, false);
const dataStoreProxy = await getDataTableProxyExecute(this, index);
const row = getAddRow(this, index);
const insertedRows = await dataStoreProxy.insertRows([row]);
return insertedRows.map((json) => ({ json }));
if (optimizeBulkEnabled) {
// This function is always called by index, so we inherently cannot operate in bulk
this.addExecutionHints({
message: 'Unable to optimize bulk insert due to expression in Data Table ID ',
location: 'outputPane',
});
const json = await dataStoreProxy.insertRows([row], 'count');
return [{ json }];
} else {
const insertedRows = await dataStoreProxy.insertRows([row], 'all');
return insertedRows.map((json, item) => ({ json, pairedItem: { item } }));
}
}
export async function executeBulk(
this: IExecuteFunctions,
proxy: IDataStoreProjectService,
): Promise<INodeExecutionData[]> {
const optimizeBulkEnabled = this.getNodeParameter('options.optimizeBulk', 0, false);
const rows = this.getInputData().flatMap((_, i) => [getAddRow(this, i)]);
const insertedRows = await proxy.insertRows(rows);
return insertedRows.map((json, item) => ({ json, pairedItem: { item } }));
if (optimizeBulkEnabled) {
const json = await proxy.insertRows(rows, 'count');
return [{ json }];
} else {
const insertedRows = await proxy.insertRows(rows, 'all');
return insertedRows.map((json, item) => ({ json, pairedItem: { item } }));
}
}