refactor: Delete a lot of unused and duplicate code in Server and WebhookServer (#5080)

* store n8n version string in a const and use that everywhere

* reduce code duplication between Server and WebhookServer

* unify redis checks

* fix linting
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-01-04 11:38:48 +01:00
committed by GitHub
parent b67f803cbe
commit 8b19fdd5f0
25 changed files with 882 additions and 1324 deletions

View File

@@ -8,6 +8,7 @@ import { IExecutionTrackProperties } from '@/Interfaces';
import { getLogger } from '@/Logger';
import { getLicense } from '@/License';
import { LicenseService } from '@/license/License.service';
import { N8N_VERSION } from '@/constants';
type ExecutionTrackDataKey = 'manual_error' | 'manual_success' | 'prod_error' | 'prod_success';
@@ -35,7 +36,7 @@ export class Telemetry {
private executionCountsBuffer: IExecutionsBuffer = {};
constructor(private instanceId: string, private versionCli: string) {}
constructor(private instanceId: string) {}
async init() {
const enabled = config.getEnv('diagnostics.enabled');
@@ -179,7 +180,7 @@ export class Telemetry {
const updatedProperties: ITelemetryTrackProperties = {
...properties,
instance_id: this.instanceId,
version_cli: this.versionCli,
version_cli: N8N_VERSION,
};
const payload = {