diff --git a/packages/nodes-base/nodes/Code/JsCodeValidator.ts b/packages/nodes-base/nodes/Code/JsCodeValidator.ts index fecb6a6854..f56de67d85 100644 --- a/packages/nodes-base/nodes/Code/JsCodeValidator.ts +++ b/packages/nodes-base/nodes/Code/JsCodeValidator.ts @@ -37,7 +37,7 @@ export function mapItemsNotDefinedErrorIfNeededForRunForAll(code: string, error: // anticipate user expecting `items` to pre-exist as in Function Item node if (error.message === 'items is not defined' && !/(let|const|var) +items +=/.test(code)) { const quoted = error.message.replace('items', '`items`'); - error.message = (quoted as string) + '. Did you mean `$input.all()`?'; + error.message = quoted + '. Did you mean `$input.all()`?'; } } @@ -49,6 +49,6 @@ export function mapItemNotDefinedErrorIfNeededForRunForEach(code: string, error: // anticipate user expecting `items` to pre-exist as in Function Item node if (error.message === 'item is not defined' && !/(let|const|var) +item +=/.test(code)) { const quoted = error.message.replace('item', '`item`'); - error.message = (quoted as string) + '. Did you mean `$input.item.json`?'; + error.message = quoted + '. Did you mean `$input.item.json`?'; } } diff --git a/packages/nodes-base/nodes/DebugHelper/DebugHelper.node.ts b/packages/nodes-base/nodes/DebugHelper/DebugHelper.node.ts index ec30bc2bd2..77ae4d861a 100644 --- a/packages/nodes-base/nodes/DebugHelper/DebugHelper.node.ts +++ b/packages/nodes-base/nodes/DebugHelper/DebugHelper.node.ts @@ -277,7 +277,6 @@ export class DebugHelper implements INodeType { message: throwErrorMessage, }); case 'Error': - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown throw new ApplicationError(throwErrorMessage); default: break; diff --git a/packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts b/packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts index bfb6d50ed3..74f7540188 100644 --- a/packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts +++ b/packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts @@ -677,7 +677,6 @@ export class EmailReadImapV2 implements INodeType { if (connection.closeBox) await connection.closeBox(false); connection.end(); } catch (error) { - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'warning' }); } }; diff --git a/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts b/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts index 70d6c29efa..9ac2189095 100644 --- a/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts +++ b/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts @@ -230,7 +230,7 @@ export async function execute( const sheetNameWithRangeForKeyRow = `${sheetNameForKeyRow}!1:${keyRowIndex}`; const sheetData = await sheet.getData(sheetNameWithRangeForKeyRow, 'FORMATTED_VALUE'); - if (sheetData === undefined || !sheetData.length) { + if (!sheetData?.length) { dataMode = 'autoMapInputData'; } diff --git a/packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts b/packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts index 3702c1e34d..ef7494d306 100644 --- a/packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts +++ b/packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts @@ -1056,10 +1056,10 @@ export class InvoiceNinja implements INodeType { const paymentId = this.getNodeParameter('paymentId', i) as string; const body: IBankTransaction = {}; if (bankTransactionId) { - body.id = bankTransactionId as string; + body.id = bankTransactionId; } if (paymentId) { - body.paymentId = paymentId as string; + body.paymentId = paymentId; } responseData = await invoiceNinjaApiRequest.call( this, diff --git a/packages/nodes-base/nodes/Kafka/Kafka.node.ts b/packages/nodes-base/nodes/Kafka/Kafka.node.ts index 11117dd653..87e9f95b0d 100644 --- a/packages/nodes-base/nodes/Kafka/Kafka.node.ts +++ b/packages/nodes-base/nodes/Kafka/Kafka.node.ts @@ -229,7 +229,6 @@ export class Kafka implements INodeType { }; if (credentials.authentication === true) { if (!(credentials.username && credentials.password)) { - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown throw new ApplicationError('Username and password are required for authentication', { level: 'warning', }); diff --git a/packages/nodes-base/nodes/MongoDb/MongoDb.node.ts b/packages/nodes-base/nodes/MongoDb/MongoDb.node.ts index 756dd72deb..14d8718b92 100644 --- a/packages/nodes-base/nodes/MongoDb/MongoDb.node.ts +++ b/packages/nodes-base/nodes/MongoDb/MongoDb.node.ts @@ -81,7 +81,6 @@ export class MongoDb implements INodeType { const { databases } = await client.db().admin().listDatabases(); if (!(databases as IDataObject[]).map((db) => db.name).includes(database)) { - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown throw new ApplicationError(`Database "${database}" does not exist`, { level: 'warning', }); diff --git a/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts b/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts index 92ba58fca3..1bf2334071 100644 --- a/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts +++ b/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts @@ -290,7 +290,7 @@ export class PostgresTrigger implements INodeType { await connection.query('SELECT 1'); } catch { // connection already closed. Can't perform cleanup - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown + throw new TriggerCloseError(this.getNode(), { level: 'warning' }); } @@ -316,7 +316,6 @@ export class PostgresTrigger implements INodeType { ]); } } catch (error) { - // eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'error' }); } } finally { diff --git a/packages/nodes-base/nodes/Transform/RemoveDuplicates/v1/RemoveDuplicatesV1.node.ts b/packages/nodes-base/nodes/Transform/RemoveDuplicates/v1/RemoveDuplicatesV1.node.ts index f4e0289107..c76c86953d 100644 --- a/packages/nodes-base/nodes/Transform/RemoveDuplicates/v1/RemoveDuplicatesV1.node.ts +++ b/packages/nodes-base/nodes/Transform/RemoveDuplicates/v1/RemoveDuplicatesV1.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import { NodeConnectionType } from 'n8n-workflow'; import type { INodeTypeBaseDescription, diff --git a/packages/nodes-base/package.json b/packages/nodes-base/package.json index dabd9da434..81126ac99e 100644 --- a/packages/nodes-base/package.json +++ b/packages/nodes-base/package.json @@ -840,7 +840,7 @@ "@types/ssh2-sftp-client": "^5.1.0", "@types/uuid": "catalog:", "@types/xml2js": "catalog:", - "eslint-plugin-n8n-nodes-base": "^1.16.2", + "eslint-plugin-n8n-nodes-base": "^1.16.3", "n8n-core": "workspace:*" }, "dependencies": { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index f174ba6fb5..28b8c62be8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1850,8 +1850,8 @@ importers: specifier: 'catalog:' version: 0.4.14 eslint-plugin-n8n-nodes-base: - specifier: ^1.16.2 - version: 1.16.2(eslint@8.57.0)(typescript@5.6.2) + specifier: ^1.16.3 + version: 1.16.3(eslint@8.57.0)(typescript@5.6.2) n8n-core: specifier: workspace:* version: link:../core @@ -7145,8 +7145,8 @@ packages: eslint-plugin-n8n-local-rules@1.0.0: resolution: {integrity: sha512-qe6sVFDP1Vj5eXlqZxYZpIjwYvhuqXlI0P8OfPyhiPOhMkFtr0TpFphD8/6WCzkm7LJCvG1eJEzURCtMIsFTAg==} - eslint-plugin-n8n-nodes-base@1.16.2: - resolution: {integrity: sha512-Qj8S+YgymYkt/5Fr1buwOTjl0jAERJBp3MA5V8M6NR1HYfErKazVjpOPEy5+04c0vAQZO1mPLGAzanxqqNUIng==} + eslint-plugin-n8n-nodes-base@1.16.3: + resolution: {integrity: sha512-edLX42Vg4B+y0kzkitTVDmHZQrG5/wUZO874N5Z9leBuxt5TG1pqMY4zdr35RlpM4p4REr/T9x+6DpsQSL63WA==} engines: {node: '>=20.15', pnpm: '>=9.6'} eslint-plugin-unicorn@51.0.1: @@ -19382,7 +19382,7 @@ snapshots: eslint-plugin-n8n-local-rules@1.0.0: {} - eslint-plugin-n8n-nodes-base@1.16.2(eslint@8.57.0)(typescript@5.6.2): + eslint-plugin-n8n-nodes-base@1.16.3(eslint@8.57.0)(typescript@5.6.2): dependencies: '@typescript-eslint/utils': 6.21.0(eslint@8.57.0)(typescript@5.6.2) camel-case: 4.1.2