From 8f99f092ffac9ce2d534e2ce779956b4dece716f Mon Sep 17 00:00:00 2001 From: Suguru Inoue Date: Mon, 8 Sep 2025 11:12:43 +0200 Subject: [PATCH] test: Refactor page objects and reuse locators (#19191) --- .../features/logs/components/LogsPanel.vue | 2 +- .../testing/playwright/pages/CanvasPage.ts | 22 +- .../playwright/pages/ExecutionsPage.ts | 15 +- packages/testing/playwright/pages/LogsPage.ts | 92 ------- .../playwright/pages/NodeDetailsViewPage.ts | 193 ++------------ .../playwright/pages/components/LogsPanel.ts | 92 +++++++ .../pages/components/RunDataPanel.ts | 125 +++++++++ packages/testing/playwright/pages/n8nPage.ts | 3 - .../playwright/tests/ui/13-pinning.spec.ts | 34 +-- .../1338-ADO-ndv-missing-input-panel.spec.ts | 4 +- .../playwright/tests/ui/14-mapping.spec.ts | 68 ++--- .../tests/ui/15-scheduler-node.spec.ts | 2 +- ...2230-ADO-ndv-reset-data-pagination.spec.ts | 9 +- .../tests/ui/28-resource-mapper.spec.ts | 24 +- .../playwright/tests/ui/31-demo.spec.ts | 4 +- .../testing/playwright/tests/ui/5-ndv.spec.ts | 132 ++++----- .../playwright/tests/ui/50-logs.spec.ts | 252 ++++++++++-------- ...ecs-broken-when-using-chat-trigger.spec.ts | 28 +- .../tests/ui/env-mock-server.spec.ts | 4 +- 19 files changed, 530 insertions(+), 575 deletions(-) delete mode 100644 packages/testing/playwright/pages/LogsPage.ts create mode 100644 packages/testing/playwright/pages/components/LogsPanel.ts create mode 100644 packages/testing/playwright/pages/components/RunDataPanel.ts diff --git a/packages/frontend/editor-ui/src/features/logs/components/LogsPanel.vue b/packages/frontend/editor-ui/src/features/logs/components/LogsPanel.vue index df5ca4eab8..e4797de8bb 100644 --- a/packages/frontend/editor-ui/src/features/logs/components/LogsPanel.vue +++ b/packages/frontend/editor-ui/src/features/logs/components/LogsPanel.vue @@ -139,7 +139,7 @@ function handleChangeOutputTableColumnCollapsing(columnName: string | null) {