admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(FileMaker Node): Improve returned error responses (#6585)

Browse Source
This commit is contained in:
Romain Dunand
2023-07-17 18:05:28 +02:00
committed by GitHub
parent 2acd71eeb1
commit 91a052e4c5
3 changed files with 18 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/nodes-base/nodes/FileMaker/FileMaker.node.ts
View File

@@ -698,10 +698,11 @@ export class FileMaker implements INodeType {
const credentials = await this.getCredentials('fileMaker');
let token;
try {
token = await getToken.call(this);
} catch (error) {
throw new NodeOperationError(this.getNode(), new Error('Login fail', { cause: error }));
throw new NodeOperationError(this.getNode(), error as string);
}
let requestOptions: OptionsWithUri;
@@ -818,21 +819,19 @@ export class FileMaker implements INodeType {
try {
response = await this.helpers.request(requestOptions);
} catch (error) {
response = error.response.body;
response = error.error;
}
if (typeof response === 'string') {
throw new NodeOperationError(
this.getNode(),
'Response body is not valid JSON. Change "Response Format" to "String"',
'DataAPI response body is not valid JSON. Is the DataAPI enabled?',
{ itemIndex: i },
);
}
returnData.push({ json: response });
}
} catch (error) {
await logout.call(this, token as string);
if (error.node) {
throw error;
}
@@ -843,6 +842,7 @@ export class FileMaker implements INodeType {
);
}
await logout.call(this, token as string);
return this.prepareOutputData(returnData);
}
}