mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 18:12:04 +00:00
fix: Run dev command only for core packages (no-changelog) (#7928)
## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. - Filters out `@n8n/chat` and `n8n-design-system` from `pnpm run dev` - Fixes dev/build error appearing due to code string `import ... from '@n8n/chat'` #### How to test the change: 1. `pnpm run dev` should work as expected 2. The command should not run for the two packages above 3. The error regarding `@n8n/chat` should no longer appear ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers https://linear.app/n8n/issue/PAY-1089/run-dev-command-only-for-core-packages ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. N/A > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
This commit is contained in:
@@ -57,9 +57,10 @@ function indentLines(code: string, indent: string = ' ') {
|
||||
.join('\n');
|
||||
}
|
||||
|
||||
const importCode = 'import';
|
||||
const commonCode = computed(() => ({
|
||||
import: `import '@n8n/chat/style.css';
|
||||
import { createChat } from '@n8n/chat';`,
|
||||
import: `${importCode} '@n8n/chat/style.css';
|
||||
${importCode} { createChat } from '@n8n/chat';`,
|
||||
createChat: `createChat({
|
||||
webhookUrl: '${webhookUrl.value}'
|
||||
});`,
|
||||
@@ -69,7 +70,7 @@ import { createChat } from '@n8n/chat';`,
|
||||
const cdnCode = computed(
|
||||
() => `<link href="https://cdn.jsdelivr.net/npm/@n8n/chat/style.css" rel="stylesheet" />
|
||||
<script type="module">
|
||||
import { createChat } from 'https://cdn.jsdelivr.net/npm/@n8n/chat/chat.bundle.es.js';
|
||||
${importCode} { createChat } from 'https://cdn.jsdelivr.net/npm/@n8n/chat/chat.bundle.es.js';
|
||||
|
||||
${commonCode.value.createChat}
|
||||
</${'script'}>`,
|
||||
@@ -77,7 +78,7 @@ ${commonCode.value.createChat}
|
||||
|
||||
const vueCode = computed(
|
||||
() => `<script lang="ts" setup>
|
||||
import { onMounted } from 'vue';
|
||||
${importCode} { onMounted } from 'vue';
|
||||
${commonCode.value.import}
|
||||
|
||||
onMounted(() => {
|
||||
@@ -87,7 +88,7 @@ ${indentLines(commonCode.value.createChat)}
|
||||
);
|
||||
|
||||
const reactCode = computed(
|
||||
() => `import { useEffect } from 'react';
|
||||
() => `${importCode} { useEffect } from 'react';
|
||||
${commonCode.value.import}
|
||||
|
||||
export const App = () => {
|
||||
|
||||
Reference in New Issue
Block a user