admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 01:56:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Wait Node): Add validation for wait amount and unit (#18239)

Browse Source
This commit is contained in:
Elias Meire
2025-08-15 08:58:49 +02:00
committed by GitHub
parent f575427d4d
commit 9515cbd60e
3 changed files with 95 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/nodes-base/nodes/Wait/Wait.node.ts
View File

@@ -14,6 +14,7 @@ import {
NodeOperationError,
} from 'n8n-workflow';
import { validateWaitAmount, validateWaitUnit } from './validation';
import { updateDisplayOptions } from '../../utils/utilities';
import {
formDescription,
@@ -47,6 +48,7 @@ const toWaitAmount: INodeProperties = {
},
default: 1,
description: 'The time to wait',
validateType: 'number',
};
const unitSelector: INodeProperties = {
@@ -487,9 +489,24 @@ export class Wait extends Webhook {
let waitTill: Date;
if (resume === 'timeInterval') {
const unit = context.getNodeParameter('unit', 0) as string;
const unit = context.getNodeParameter('unit', 0);
if (!validateWaitUnit(unit)) {
throw new NodeOperationError(
context.getNode(),
"Invalid wait unit. Valid units are 'seconds', 'minutes', 'hours', or 'days'.",
);
}
let waitAmount = context.getNodeParameter('amount', 0);
if (!validateWaitAmount(waitAmount)) {
throw new NodeOperationError(
context.getNode(),
'Invalid wait amount. It must be a positive number.',
);
}
let waitAmount = context.getNodeParameter('amount', 0) as number;
if (unit === 'minutes') {
waitAmount *= 60;
}
@@ -514,7 +531,7 @@ export class Wait extends Webhook {
} catch (e) {
throw new NodeOperationError(
context.getNode(),
'[Wait node] Cannot put execution to wait because `dateTime` parameter is not a valid date. Please pick a specific date and time to wait until.',
'Cannot put execution to wait because `dateTime` parameter is not a valid date. Please pick a specific date and time to wait until.',
);
}
}