fix(X (Formerly Twitter) Node): Change how tweet id is retrieved from quote URL (#9635)

Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Twitter/test/Twitter.test.ts

@@ -1,4 +1,6 @@
 import nock from 'nock';
+import type { INodeParameterResourceLocator } from 'n8n-workflow';
+import { returnId } from '../V2/GenericFunctions';
 import { getWorkflowFilenames, testWorkflows } from '@test/nodes/Helpers';
 
 const searchResult = {
@@ -66,6 +68,7 @@ const searchResult = {
 const meResult = {
 	data: { id: '1285192200213626880', name: 'Integration-n8n', username: 'IntegrationN8n' },
 };
+
 describe('Test Twitter Request Node', () => {
 	beforeAll(() => {
 		const baseUrl = 'https://api.twitter.com/2';
@@ -85,3 +88,60 @@ describe('Test Twitter Request Node', () => {
 	const workflows = getWorkflowFilenames(__dirname);
 	testWorkflows(workflows);
 });
+
+describe('X / Twitter Node unit tests', () => {
+	describe('returnId', () => {
+		it('should return the id when mode is id', () => {
+			const tweetId: INodeParameterResourceLocator = {
+				__rl: true,
+				mode: 'id',
+				value: '12345',
+			};
+			expect(returnId(tweetId)).toBe('12345');
+		});
+
+		it('should extract the tweetId from url when the domain is twitter.com', () => {
+			const tweetId: INodeParameterResourceLocator = {
+				__rl: true,
+				mode: 'url',
+				value: 'https://twitter.com/user/status/12345?utm=6789',
+			};
+			expect(returnId(tweetId)).toBe('12345');
+		});
+
+		it('should extract the tweetId from url when the domain is x.com', () => {
+			const tweetId: INodeParameterResourceLocator = {
+				__rl: true,
+				mode: 'url',
+				value: 'https://x.com/user/status/12345?utm=6789',
+			};
+			expect(returnId(tweetId)).toBe('12345');
+		});
+
+		it('should throw an error when mode is not valid', () => {
+			const tweetId: INodeParameterResourceLocator = {
+				__rl: true,
+				mode: 'invalid',
+				value: 'https://twitter.com/user/status/12345',
+			};
+			expect(() => returnId(tweetId)).toThrow();
+		});
+
+		describe('should throw an error when the URL is not valid', () => {
+			test.each([
+				'https://twitter.com/user/',
+				'https://twitter.com/user/status/',
+				'https://twitter.com/user/profile/12345',
+				'https://twitter.com/search?param=12345',
+			])('%s', (value) => {
+				expect(() =>
+					returnId({
+						__rl: true,
+						mode: 'url',
+						value,
+					}),
+				).toThrow();
+			});
+		});
+	});
+});