admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Postgres Node): Allow passing in arrays to JSON columns for insert (#12452)

Browse Source
This commit is contained in:
Dana
2025-01-08 10:41:51 +01:00
committed by GitHub
parent 2c72047d0b
commit 9dd068632b
5 changed files with 185 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts
View File

@@ -1,5 +1,6 @@
import type { IDataObject, INode } from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow';
import pgPromise from 'pg-promise';
import type { ColumnInfo } from '../../v2/helpers/interfaces';
import {
@@ -14,6 +15,8 @@ import {
wrapData,
convertArraysToPostgresFormat,
isJSON,
convertValuesToJsonWithPgp,
hasJsonDataTypeInSchema,
} from '../../v2/helpers/utils';
const node: INode = {
@@ -387,6 +390,57 @@ describe('Test PostgresV2, checkItemAgainstSchema', () => {
});
});
describe('Test PostgresV2, hasJsonDataType', () => {
it('returns true if there are columns which are of type json', () => {
const schema: ColumnInfo[] = [
{ column_name: 'data', data_type: 'json', is_nullable: 'YES' },
{ column_name: 'id', data_type: 'integer', is_nullable: 'NO' },
];
expect(hasJsonDataTypeInSchema(schema)).toEqual(true);
});
it('returns false if there are columns which are of type json', () => {
const schema: ColumnInfo[] = [{ column_name: 'id', data_type: 'integer', is_nullable: 'NO' }];
expect(hasJsonDataTypeInSchema(schema)).toEqual(false);
});
});
describe('Test PostgresV2, convertValuesToJsonWithPgp', () => {
it('should use pgp to properly convert values to JSON', () => {
const pgp = pgPromise();
const pgpJsonSpy = jest.spyOn(pgp.as, 'json');
const schema: ColumnInfo[] = [
{ column_name: 'data', data_type: 'json', is_nullable: 'YES' },
{ column_name: 'id', data_type: 'integer', is_nullable: 'NO' },
];
const values = [
{
value: { data: [], id: 1 },
expected: { data: '[]', id: 1 },
},
{
value: { data: [0], id: 1 },
expected: { data: '[0]', id: 1 },
},
{
value: { data: { key: 2 }, id: 1 },
expected: { data: '{"key":2}', id: 1 },
},
];
values.forEach((value) => {
const data = value.value.data;
expect(convertValuesToJsonWithPgp(pgp, schema, value.value)).toEqual(value.expected);
expect(value.value).toEqual(value.expected);
expect(pgpJsonSpy).toHaveBeenCalledWith(data, true);
});
});
});
describe('Test PostgresV2, convertArraysToPostgresFormat', () => {
it('should convert js arrays to postgres format', () => {
const item = {