From 29eab1dbcd529c56825d470f10cdb90bf185e213 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Tue, 29 Jun 2021 07:28:02 +0200 Subject: [PATCH 01/74] :bug: Fix Pipedrive SVG icon (#1948) * :art: Fix Pipedrive SVG icon * :zap: Except Pipedrive SVG from optimizer --- package.json | 2 +- packages/nodes-base/nodes/Pipedrive/pipedrive.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 44145dbb5e..8855d43d8f 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "build": "lerna exec npm run build", "dev": "lerna exec npm run dev --parallel", "clean:dist": "lerna exec -- rimraf ./dist", - "optimize-svg": "find ./packages -name '*.svg' -print0 | xargs -0 -P16 -L20 npx svgo", + "optimize-svg": "find ./packages -name '*.svg' ! -name 'pipedrive.svg' -print0 | xargs -0 -P16 -L20 npx svgo", "start": "run-script-os", "start:default": "cd packages/cli/bin && ./n8n", "start:windows": "cd packages/cli/bin && n8n", diff --git a/packages/nodes-base/nodes/Pipedrive/pipedrive.svg b/packages/nodes-base/nodes/Pipedrive/pipedrive.svg index 281d3fd12e..fb3daef773 100644 --- a/packages/nodes-base/nodes/Pipedrive/pipedrive.svg +++ b/packages/nodes-base/nodes/Pipedrive/pipedrive.svg @@ -1 +1 @@ - \ No newline at end of file + From b2e2cfa773dfbffea238a499220ba025eee398e4 Mon Sep 17 00:00:00 2001 From: Ricardo Espinoza Date: Tue, 29 Jun 2021 04:40:47 -0400 Subject: [PATCH 02/74] :bug: Handle bit (boolean) values correctly when inserting (#1949) --- packages/nodes-base/nodes/Microsoft/Sql/GenericFunctions.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/nodes-base/nodes/Microsoft/Sql/GenericFunctions.ts b/packages/nodes-base/nodes/Microsoft/Sql/GenericFunctions.ts index d01643c124..cff19da729 100644 --- a/packages/nodes-base/nodes/Microsoft/Sql/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Microsoft/Sql/GenericFunctions.ts @@ -102,6 +102,8 @@ export function extractValues(item: IDataObject): string { return 'NULL'; } else if (typeof val === 'string') { return `'${val.replace(/'/g, '\'\'')}'`; + } else if (typeof val === 'boolean') { + return +!!val; } return val; }) // maybe other types such as dates have to be handled as well From a4d0c0fcad4c672bbba59cf2ba9c26bcb0b691a4 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Tue, 29 Jun 2021 11:47:28 +0300 Subject: [PATCH 03/74] :bug: Fix keyboard shortcut issues (#1934) * fix keyboard shortcut issues * remove duplicate check * remove duplicate check --- packages/editor-ui/src/modules/ui.ts | 3 --- packages/editor-ui/src/views/NodeView.vue | 29 ++++++++++++++++------- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/packages/editor-ui/src/modules/ui.ts b/packages/editor-ui/src/modules/ui.ts index 9fbe35fb37..a5681f4a84 100644 --- a/packages/editor-ui/src/modules/ui.ts +++ b/packages/editor-ui/src/modules/ui.ts @@ -31,9 +31,6 @@ const module: Module = { isModalActive: (state: IUiState) => { return (name: string) => state.modalStack.length > 0 && name === state.modalStack[0]; }, - anyModalsOpen: (state: IUiState) => { - return state.modalStack.length > 0; - }, sidebarMenuCollapsed: (state: IUiState): boolean => state.sidebarMenuCollapsed, }, mutations: { diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue index 617aabcb41..7904b4eb0e 100644 --- a/packages/editor-ui/src/views/NodeView.vue +++ b/packages/editor-ui/src/views/NodeView.vue @@ -514,15 +514,29 @@ export default mixins( // else which should ignore the default keybindings for (let index = 0; index < path.length; index++) { if (path[index].className && typeof path[index].className === 'string' && ( - path[index].className.includes('el-message-box') || - path[index].className.includes('el-select') || path[index].className.includes('ignore-key-press') )) { return; } } - const anyModalsOpen = this.$store.getters['ui/anyModalsOpen']; - if (anyModalsOpen) { + + // el-dialog or el-message-box element is open + if (window.document.body.classList.contains('el-popup-parent--hidden')) { + return; + } + + if (e.key === 'Escape') { + this.createNodeActive = false; + if (this.activeNode) { + this.$externalHooks().run('dataDisplay.nodeEditingFinished'); + this.$store.commit('setActiveNode', null); + } + + return; + } + + // node modal is open + if (this.activeNode) { return; } @@ -533,15 +547,12 @@ export default mixins( e.preventDefault(); this.callDebounced('deleteSelectedNodes', 500); - } else if (e.key === 'Escape') { - this.$externalHooks().run('dataDisplay.nodeEditingFinished'); - this.createNodeActive = false; - this.$store.commit('setActiveNode', null); + } else if (e.key === 'Tab') { this.createNodeActive = !this.createNodeActive && !this.isReadOnly; } else if (e.key === this.controlKeyCode) { this.ctrlKeyPressed = true; - } else if (e.key === 'F2') { + } else if (e.key === 'F2' && !this.isReadOnly) { const lastSelectedNode = this.lastSelectedNode; if (lastSelectedNode !== null) { this.callDebounced('renameNodePrompt', 1500, lastSelectedNode.name); From 857a55a608da9fb9774ba1fa26888eccf7801c65 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Tue, 29 Jun 2021 10:55:01 +0200 Subject: [PATCH 04/74] :bookmark: Release n8n-nodes-base@0.123.1 --- packages/nodes-base/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nodes-base/package.json b/packages/nodes-base/package.json index 6821dbb88e..5be403bb31 100644 --- a/packages/nodes-base/package.json +++ b/packages/nodes-base/package.json @@ -1,6 +1,6 @@ { "name": "n8n-nodes-base", - "version": "0.123.0", + "version": "0.123.1", "description": "Base nodes of n8n", "license": "SEE LICENSE IN LICENSE.md", "homepage": "https://n8n.io", From 3a2456a88e31a77c542123640089af8a20ceab92 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Tue, 29 Jun 2021 10:56:43 +0200 Subject: [PATCH 05/74] :bookmark: Release n8n-editor-ui@0.96.1 --- packages/editor-ui/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor-ui/package.json b/packages/editor-ui/package.json index f829f339f0..54e7eb8f52 100644 --- a/packages/editor-ui/package.json +++ b/packages/editor-ui/package.json @@ -1,6 +1,6 @@ { "name": "n8n-editor-ui", - "version": "0.96.0", + "version": "0.96.1", "description": "Workflow Editor UI for n8n", "license": "SEE LICENSE IN LICENSE.md", "homepage": "https://n8n.io", From 312eb827f5cdba2d173ecd70a5bdffe3ec0ee512 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Tue, 29 Jun 2021 10:57:45 +0200 Subject: [PATCH 06/74] :arrow_up: Set n8n-editor-ui@0.96.1 and n8n-nodes-base@0.123.1 on n8n --- packages/cli/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index 4c095c3960..d7da7ef50f 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -107,8 +107,8 @@ "lodash.get": "^4.4.2", "mysql2": "~2.2.0", "n8n-core": "~0.75.0", - "n8n-editor-ui": "~0.96.0", - "n8n-nodes-base": "~0.123.0", + "n8n-editor-ui": "~0.96.1", + "n8n-nodes-base": "~0.123.1", "n8n-workflow": "~0.62.0", "oauth-1.0a": "^2.2.6", "open": "^7.0.0", From 38f0cc1a8f53c80d48d2b1d754f2faa0c406cfec Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Tue, 29 Jun 2021 10:58:44 +0200 Subject: [PATCH 07/74] :bookmark: Release n8n@0.126.1 --- packages/cli/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index d7da7ef50f..ca4a198df1 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -1,6 +1,6 @@ { "name": "n8n", - "version": "0.126.0", + "version": "0.126.1", "description": "n8n Workflow Automation Tool", "license": "SEE LICENSE IN LICENSE.md", "homepage": "https://n8n.io", From a080fab1f1e0c7b74491358d27d83133c6113ad4 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Wed, 30 Jun 2021 10:17:30 +0300 Subject: [PATCH 08/74] :zap: Update click outside events to limit only to click events, ignoring blur (#1953) --- .../components/ExpandableInput/ExpandableInputEdit.vue | 8 +++++--- .../editor-ui/src/components/NodeCreator/NodeCreator.vue | 8 +++++--- packages/editor-ui/src/components/TagsDropdown.vue | 8 +++++--- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/packages/editor-ui/src/components/ExpandableInput/ExpandableInputEdit.vue b/packages/editor-ui/src/components/ExpandableInput/ExpandableInputEdit.vue index bed1a0c495..b90d8cfb38 100644 --- a/packages/editor-ui/src/components/ExpandableInput/ExpandableInputEdit.vue +++ b/packages/editor-ui/src/components/ExpandableInput/ExpandableInputEdit.vue @@ -10,7 +10,7 @@ @keydown.esc="onEscape" ref="input" size="4" - v-click-outside="onBlur" + v-click-outside="onClickOutside" /> @@ -47,8 +47,10 @@ export default Vue.extend({ onEnter() { this.$emit('enter', (this.$refs.input as HTMLInputElement).value); }, - onBlur() { - this.$emit('blur', (this.$refs.input as HTMLInputElement).value); + onClickOutside(e: Event) { + if (e.type === 'click') { + this.$emit('blur', (this.$refs.input as HTMLInputElement).value); + } }, onEscape() { this.$emit('esc'); diff --git a/packages/editor-ui/src/components/NodeCreator/NodeCreator.vue b/packages/editor-ui/src/components/NodeCreator/NodeCreator.vue index 4c9eccf5e0..ea36daf9be 100644 --- a/packages/editor-ui/src/components/NodeCreator/NodeCreator.vue +++ b/packages/editor-ui/src/components/NodeCreator/NodeCreator.vue @@ -1,7 +1,7 @@