From a1504cf42b26efa8e08bb78b0bf685efd77c4091 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Tue, 2 Sep 2025 10:19:57 +0200 Subject: [PATCH] chore: Remove "User added action" telemetry event (#19051) --- .../NodeCreator/composables/useActions.ts | 1 - .../src/stores/nodeCreator.store.test.ts | 25 ------------------- .../editor-ui/src/stores/nodeCreator.store.ts | 11 -------- 3 files changed, 37 deletions(-) diff --git a/packages/frontend/editor-ui/src/components/Node/NodeCreator/composables/useActions.ts b/packages/frontend/editor-ui/src/components/Node/NodeCreator/composables/useActions.ts index e07821ea7f..8ed57dead7 100644 --- a/packages/frontend/editor-ui/src/components/Node/NodeCreator/composables/useActions.ts +++ b/packages/frontend/editor-ui/src/components/Node/NodeCreator/composables/useActions.ts @@ -397,7 +397,6 @@ export const useActions = () => { resource: (action.value as INodeParameters).resource || '', }; void useExternalHooks().run('nodeCreateList.addAction', payload); - useNodeCreatorStore().onAddActions(payload); } return { diff --git a/packages/frontend/editor-ui/src/stores/nodeCreator.store.test.ts b/packages/frontend/editor-ui/src/stores/nodeCreator.store.test.ts index 5e0d614611..3cf6737e23 100644 --- a/packages/frontend/editor-ui/src/stores/nodeCreator.store.test.ts +++ b/packages/frontend/editor-ui/src/stores/nodeCreator.store.test.ts @@ -21,9 +21,6 @@ const node_type = 'node-type'; const node_id = 'node-id'; const node_version = 1; const input_node_type = 'input-node-type'; -const action = 'action'; -const source_mode = 'source-mode'; -const resource = 'resource'; const actions = ['action1']; vi.mock('@/composables/useTelemetry', () => { @@ -162,28 +159,6 @@ describe('useNodeCreatorStore', () => { }); }); - it('tracks event when action is added', () => { - nodeCreatorStore.onCreatorOpened({ - source, - mode, - workflow_id, - }); - nodeCreatorStore.onAddActions({ - node_type, - action, - source_mode, - resource, - }); - - expect(useTelemetry().track).toHaveBeenCalledWith('User added action', { - node_type, - action, - source_mode, - resource, - nodes_panel_session_id: getSessionId(now), - }); - }); - it('tracks when custom api action is clicked', () => { nodeCreatorStore.onCreatorOpened({ source, diff --git a/packages/frontend/editor-ui/src/stores/nodeCreator.store.ts b/packages/frontend/editor-ui/src/stores/nodeCreator.store.ts index bec40af356..2a71b617ae 100644 --- a/packages/frontend/editor-ui/src/stores/nodeCreator.store.ts +++ b/packages/frontend/editor-ui/src/stores/nodeCreator.store.ts @@ -23,7 +23,6 @@ import { transformNodeType } from '@/components/Node/NodeCreator/utils'; import type { IDataObject, INodeInputConfiguration, - NodeParameterValueType, NodeConnectionType, Workflow, } from 'n8n-workflow'; @@ -391,15 +390,6 @@ export const useNodeCreatorStore = defineStore(STORES.NODE_CREATOR, () => { trackNodeCreatorEvent('User clicked custom API from node actions', properties); } - function onAddActions(properties: { - node_type?: string; - action: string; - source_mode: string; - resource: NodeParameterValueType; - }) { - trackNodeCreatorEvent('User added action', properties); - } - function onSubcategorySelected(properties: { subcategory: string }) { trackNodeCreatorEvent('User viewed node category', { category_name: properties.subcategory, @@ -459,7 +449,6 @@ export const useNodeCreatorStore = defineStore(STORES.NODE_CREATOR, () => { onCategoryExpanded, onActionsCustomAPIClicked, onViewActions, - onAddActions, onSubcategorySelected, onNodeAddedToCanvas, };