Revert "chore(core): Use roles from database in global roles (#17853)" (#18738)

This commit is contained in:
Andreas Fitzek
2025-08-25 14:29:28 +02:00
committed by GitHub
parent b62c957c71
commit a21a03d4b0
117 changed files with 410 additions and 875 deletions

View File

@@ -61,7 +61,7 @@ describe('--deleteWorkflowsAndCredentials', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
const memberProject = await getPersonalProject(member);
const workflow = await createWorkflow({}, member);
const credential = await saveCredential(randomCredentialPayload(), {
@@ -166,7 +166,7 @@ describe('--userId', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
await expect(command.run([`--userId=${member.id}`])).rejects.toThrowError(
`Can't migrate workflows and credentials to the user with the ID ${member.id}. That user was created via LDAP and will be deleted as well.`,
@@ -177,7 +177,7 @@ describe('--userId', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
const memberProject = await getPersonalProject(member);
const workflow = await createWorkflow({}, member);
const credential = await saveCredential(randomCredentialPayload(), {
@@ -242,7 +242,7 @@ describe('--projectId', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
const memberProject = await getPersonalProject(member);
await expect(command.run([`--projectId=${memberProject.id}`])).rejects.toThrowError(
@@ -254,7 +254,7 @@ describe('--projectId', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
const memberProject = await getPersonalProject(member);
const workflow = await createWorkflow({}, member);
const credential = await saveCredential(randomCredentialPayload(), {
@@ -310,7 +310,7 @@ describe('--projectId', () => {
//
// ARRANGE
//
const member = await createLdapUser({ role: { slug: 'global:member' } }, uuid());
const member = await createLdapUser({ role: 'global:member' }, uuid());
const memberProject = await getPersonalProject(member);
const workflow = await createWorkflow({}, member);
const credential = await saveCredential(randomCredentialPayload(), {

View File

@@ -12,7 +12,6 @@ import {
SharedCredentialsRepository,
SharedWorkflowRepository,
UserRepository,
GLOBAL_OWNER_ROLE,
} from '@n8n/db';
import { Container } from '@n8n/di';
@@ -36,7 +35,7 @@ test('user-management:reset should reset DB to default user state', async () =>
//
// ARRANGE
//
const owner = await createUser({ role: GLOBAL_OWNER_ROLE });
const owner = await createUser({ role: 'global:owner' });
const ownerProject = await getPersonalProject(owner);
// should be deleted
@@ -71,7 +70,7 @@ test('user-management:reset should reset DB to default user state', async () =>
// check if the owner account was reset:
await expect(
Container.get(UserRepository).findOneBy({ role: { slug: GLOBAL_OWNER_ROLE.slug } }),
Container.get(UserRepository).findOneBy({ role: 'global:owner' }),
).resolves.toMatchObject({
email: null,
firstName: null,
@@ -81,9 +80,7 @@ test('user-management:reset should reset DB to default user state', async () =>
});
// all members were deleted:
const members = await Container.get(UserRepository).findOneBy({
role: { slug: 'global:member' },
});
const members = await Container.get(UserRepository).findOneBy({ role: 'global:member' });
expect(members).toBeNull();
// all workflows are owned by the owner: