From acfc4fc39dac367c82facb9d61e0efabe56d257d Mon Sep 17 00:00:00 2001 From: ricardo Date: Sun, 14 Jun 2020 21:39:30 -0400 Subject: [PATCH] :zap: Improvements to PagerDuty-Node --- .../credentials/PagerDutyOAuth2Api.credentials.ts | 8 +++++++- packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts | 8 ++++---- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/packages/nodes-base/credentials/PagerDutyOAuth2Api.credentials.ts b/packages/nodes-base/credentials/PagerDutyOAuth2Api.credentials.ts index 0bdd68b9c9..28b44011db 100644 --- a/packages/nodes-base/credentials/PagerDutyOAuth2Api.credentials.ts +++ b/packages/nodes-base/credentials/PagerDutyOAuth2Api.credentials.ts @@ -26,7 +26,13 @@ export class PagerDutyOAuth2Api implements ICredentialType { displayName: 'Auth URI Query Parameters', name: 'authQueryParameters', type: 'hidden' as NodePropertyTypes, - default: 'grant_type=authorization_code', + default: '', + }, + { + displayName: 'Scope', + name: 'scope', + type: 'hidden' as NodePropertyTypes, + default: '', }, { displayName: 'Authentication', diff --git a/packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts b/packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts index 716b4e0d5e..f4832b923c 100644 --- a/packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts +++ b/packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts @@ -45,7 +45,7 @@ export async function pagerDutyApiRequest(this: IExecuteFunctions | IWebhookFunc options.headers = Object.assign({}, options.headers, headers); try { - if (authenticationMethod === 'accessToken') { + if (authenticationMethod === 'apiToken') { const credentials = this.getCredentials('pagerDutyApi'); if (credentials === undefined) { diff --git a/packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts b/packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts index f9b8b1e3c7..8d62b8fc6f 100644 --- a/packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts +++ b/packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts @@ -69,7 +69,7 @@ export class PagerDuty implements INodeType { displayOptions: { show: { authentication: [ - 'accessToken', + 'apiToken', ], }, }, @@ -93,15 +93,15 @@ export class PagerDuty implements INodeType { type: 'options', options: [ { - name: 'Access Token', - value: 'accessToken', + name: 'API Token', + value: 'apiToken', }, { name: 'OAuth2', value: 'oAuth2', }, ], - default: 'accessToken', + default: 'apiToken', }, { displayName: 'Resource',