admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Improve warnings and error messages to users about sharing (#4687) (no-changelog)

Browse Source 
* refactor: Improve warnings and error messages to users about sharing
This commit is contained in:
Omar Ajoue
2022-11-22 13:05:51 +01:00
committed by GitHub
parent 91408dccf5
commit ad6c6f60a1
7 changed files with 33 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/cli/src/workflows/workflows.controller.ee.ts
View File

@@ -87,7 +87,7 @@ EEWorkflowController.get(
if (!workflow) {
throw new ResponseHelper.ResponseError(
`Workflow with ID "${workflowId}" could not be found.`,
`Workflow with ID "${workflowId}" does not exist`,
undefined,
404,
);
@@ -96,7 +96,11 @@ EEWorkflowController.get(
const userSharing = workflow.shared?.find((shared) => shared.user.id === req.user.id);
if (!userSharing && req.user.globalRole.name !== 'owner') {
throw new ResponseHelper.ResponseError(`Forbidden.`, undefined, 403);
throw new ResponseHelper.ResponseError(
'It looks like you cannot access this workflow. Ask the owner to share it with you.',
undefined,
403,
);
}
return EEWorkflows.addCredentialsToWorkflow(
@@ -140,7 +144,7 @@ EEWorkflowController.post(
EEWorkflows.validateCredentialPermissionsToUser(newWorkflow, allCredentials);
} catch (error) {
throw new ResponseHelper.ResponseError(
'The workflow contains credentials that you do not have access to',
'The workflow you are trying to save contains credentials that are not shared with you',
undefined,
400,
);
@@ -169,7 +173,9 @@ EEWorkflowController.post(
if (!savedWorkflow) {
LoggerProxy.error('Failed to create workflow', { userId: req.user.id });
throw new ResponseHelper.ResponseError('Failed to save workflow');
throw new ResponseHelper.ResponseError(
'An error occurred while saving your workflow. Please try again.',
);
}
if (tagIds && !config.getEnv('workflowTagsDisabled') && savedWorkflow.tags) {