admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Fix zero treated as missing value in resource locator (#4612)

Browse Source 
* 🐛 Adding a type guard to validate resource locator parameter values
* ✔️ Fixing a linting error
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Milorad FIlipović
2022-11-16 09:21:30 +01:00
committed by GitHub
parent 53d2526cd1
commit b0bbcf6028
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/workflow/src/NodeHelpers.ts
View File

@@ -38,6 +38,7 @@ import {
NodeParameterValue,
WebhookHttpMethod,
} from './Interfaces';
import { isValidResourceLocatorParameterValue } from './type-guards';
import { deepCopy } from './utils';
import type { Workflow } from './Workflow';
@@ -1150,7 +1151,7 @@ export function addToIssuesIfMissing(
(nodeProperties.type === 'dateTime' && value === undefined) ||
(nodeProperties.type === 'options' && (value === '' || value === undefined)) ||
(nodeProperties.type === 'resourceLocator' &&
(!value || (typeof value === 'object' && !value.value)))
!isValidResourceLocatorParameterValue(value as INodeParameterResourceLocator))
) {
// Parameter is required but empty
if (foundIssues.parameters === undefined) {