From b2201d0c77cf024e39f6569e7806871d38408201 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Thu, 10 Nov 2022 21:44:31 +0100 Subject: [PATCH] fix: Disable some error tracking (#4579) * fix: remove error tracking for Circular reference in deepCopy * fix: remove error tracking on crash detection --- packages/cli/src/CrashJournal.ts | 3 +-- packages/workflow/src/utils.ts | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/cli/src/CrashJournal.ts b/packages/cli/src/CrashJournal.ts index 71803ec7b8..da29d2b07f 100644 --- a/packages/cli/src/CrashJournal.ts +++ b/packages/cli/src/CrashJournal.ts @@ -2,7 +2,7 @@ import { existsSync } from 'fs'; import { mkdir, utimes, open, rm } from 'fs/promises'; import { join, dirname } from 'path'; import { UserSettings } from 'n8n-core'; -import { ErrorReporterProxy as ErrorReporter, LoggerProxy, sleep } from 'n8n-workflow'; +import { LoggerProxy, sleep } from 'n8n-workflow'; export const touchFile = async (filePath: string): Promise => { await mkdir(dirname(filePath), { recursive: true }); @@ -20,7 +20,6 @@ const journalFile = join(UserSettings.getUserN8nFolderPath(), 'crash.journal'); export const init = async () => { if (existsSync(journalFile)) { // Crash detected - ErrorReporter.warn('Last session crashed'); LoggerProxy.error('Last session crashed'); // add a 10 seconds pause to slow down crash-looping await sleep(10_000); diff --git a/packages/workflow/src/utils.ts b/packages/workflow/src/utils.ts index 0a6c1c98a7..939e303a4b 100644 --- a/packages/workflow/src/utils.ts +++ b/packages/workflow/src/utils.ts @@ -1,5 +1,3 @@ -import * as ErrorReporter from './ErrorReporterProxy'; - export type Primitives = string | number | boolean | bigint | symbol | null | undefined; /* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-argument */ @@ -19,9 +17,6 @@ export const deepCopy = string }) return source.toJSON() as T; } if (hash.has(source)) { - ErrorReporter.warn('Circular reference detected', { - extra: { source, path }, - }); return hash.get(source); } // Array