fix(Salesforce Trigger Node): Update polling logic to account for Salesforce processing delay (#19377)

packages/nodes-base/nodes/Salesforce/__test__/GenericFunctions.test.ts

@@ -6,6 +6,7 @@ import {
 	sortOptions,
 	getDefaultFields,
 	getQuery,
+	filterAndManageProcessedItems,
 } from '../GenericFunctions';
 
 describe('Salesforce -> GenericFunctions', () => {
@@ -217,4 +218,136 @@ describe('Salesforce -> GenericFunctions', () => {
 			expect(result).toBe('SELECT id,name,email FROM Account WHERE id = 123 LIMIT 5');
 		});
 	});
+
+	describe('filterAndManageProcessedItems', () => {
+		it('should filter out already processed items', () => {
+			const responseData: IDataObject[] = [
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '002', Name: 'Item 2' },
+				{ Id: '003', Name: 'Item 3' },
+			];
+			const processedIds = ['002'];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toEqual([
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '003', Name: 'Item 3' },
+			]);
+			// '002' is removed since it was encountered, only new items remain
+			expect(result.updatedProcessedIds).toEqual(['001', '003']);
+		});
+
+		it('should handle empty response data', () => {
+			const responseData: IDataObject[] = [];
+			const processedIds = ['001', '002'];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toEqual([]);
+			expect(result.updatedProcessedIds).toEqual(['001', '002']);
+		});
+
+		it('should handle empty processed IDs', () => {
+			const responseData: IDataObject[] = [
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '002', Name: 'Item 2' },
+			];
+			const processedIds: string[] = [];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toEqual(responseData);
+			expect(result.updatedProcessedIds).toEqual(['001', '002']);
+		});
+
+		it('should handle all items already processed', () => {
+			const responseData: IDataObject[] = [
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '002', Name: 'Item 2' },
+			];
+			const processedIds = ['001', '002', '003'];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toEqual([]);
+			// Should only keep '003' since '001' and '002' were encountered and removed
+			expect(result.updatedProcessedIds).toEqual(['003']);
+		});
+
+		it('should handle large numbers of processed IDs efficiently', () => {
+			// Create 995 existing processed IDs
+			const processedIds = Array.from({ length: 995 }, (_, i) => `existing-${i}`);
+
+			// Add 10 new items
+			const responseData: IDataObject[] = Array.from({ length: 10 }, (_, i) => ({
+				Id: `new-${i}`,
+				Name: `New Item ${i}`,
+			}));
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toHaveLength(10);
+			// Should keep all existing IDs + 10 new IDs (no artificial limit)
+			expect(result.updatedProcessedIds).toHaveLength(1005);
+
+			// Should keep all existing IDs + new IDs
+			expect(result.updatedProcessedIds.slice(0, 995)).toEqual(processedIds);
+			expect(result.updatedProcessedIds.slice(-10)).toEqual(
+				responseData.map((item) => item.Id as string),
+			);
+		});
+
+		it('should handle very large batches of new items', () => {
+			const processedIds = ['existing-1', 'existing-2'];
+
+			// Create 1005 new items
+			const responseData: IDataObject[] = Array.from({ length: 1005 }, (_, i) => ({
+				Id: `new-${i}`,
+				Name: `New Item ${i}`,
+			}));
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.newItems).toHaveLength(1005);
+			// Should keep all existing IDs + all new IDs (no artificial limit)
+			expect(result.updatedProcessedIds).toHaveLength(1007);
+
+			// Should keep all existing IDs + all new IDs
+			const expectedIds = processedIds.concat(responseData.map((item) => item.Id as string));
+			expect(result.updatedProcessedIds).toEqual(expectedIds);
+		});
+
+		it('should handle duplicate IDs in response data correctly', () => {
+			const responseData: IDataObject[] = [
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '002', Name: 'Item 2' },
+				{ Id: '001', Name: 'Item 1 Duplicate' }, // Duplicate ID
+			];
+			const processedIds = ['003'];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			// Should include both items with ID '001' since they're not in processedIds
+			expect(result.newItems).toEqual([
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '002', Name: 'Item 2' },
+				{ Id: '001', Name: 'Item 1 Duplicate' },
+			]);
+			expect(result.updatedProcessedIds).toEqual(['003', '001', '002', '001']);
+		});
+
+		it('should maintain order of processed IDs', () => {
+			const responseData: IDataObject[] = [
+				{ Id: '003', Name: 'Item 3' },
+				{ Id: '001', Name: 'Item 1' },
+				{ Id: '004', Name: 'Item 4' },
+			];
+			const processedIds = ['100', '200'];
+
+			const result = filterAndManageProcessedItems(responseData, processedIds);
+
+			expect(result.updatedProcessedIds).toEqual(['100', '200', '003', '001', '004']);
+		});
+	});
 });