diff --git a/cypress/e2e/4-node-creator.cy.ts b/cypress/e2e/4-node-creator.cy.ts index 187345e940..5e081ce870 100644 --- a/cypress/e2e/4-node-creator.cy.ts +++ b/cypress/e2e/4-node-creator.cy.ts @@ -271,7 +271,7 @@ describe('Node Creator', () => { NDVModal.actions.close(); WorkflowPage.getters.canvasNodes().should('have.length', 2); WorkflowPage.actions.zoomToFit(); - WorkflowPage.actions.addNodeBetweenNodes('n8n', 'n8n1', 'Item Lists') + WorkflowPage.actions.addNodeBetweenNodes('n8n', 'n8n1', 'Item Lists', 'Summarize') WorkflowPage.getters.canvasNodes().should('have.length', 3); }) }); diff --git a/cypress/pages/workflow.ts b/cypress/pages/workflow.ts index 8b6d195105..a17c52c9cf 100644 --- a/cypress/pages/workflow.ts +++ b/cypress/pages/workflow.ts @@ -241,14 +241,15 @@ export class WorkflowPage extends BasePage { executeWorkflow: () => { this.getters.executeWorkflowButton().click(); }, - addNodeBetweenNodes: (sourceNodeName: string, targetNodeName: string, newNodeName: string) => { + addNodeBetweenNodes: (sourceNodeName: string, targetNodeName: string, newNodeName: string, action?: string) => { this.getters.getConnectionBetweenNodes(sourceNodeName, targetNodeName).first().realHover(); this.getters .getConnectionActionsBetweenNodes(sourceNodeName, targetNodeName) .find('.add') .first() .click({ force: true }); - this.actions.addNodeToCanvas(newNodeName, false); + + this.actions.addNodeToCanvas(newNodeName, false, false, action); }, deleteNodeBetweenNodes: ( sourceNodeName: string, diff --git a/packages/editor-ui/src/components/Node/NodeCreator/Modes/ActionsMode.vue b/packages/editor-ui/src/components/Node/NodeCreator/Modes/ActionsMode.vue index ba2e246536..1170f54bf1 100644 --- a/packages/editor-ui/src/components/Node/NodeCreator/Modes/ActionsMode.vue +++ b/packages/editor-ui/src/components/Node/NodeCreator/Modes/ActionsMode.vue @@ -13,10 +13,8 @@ import { REGULAR_NODE_CREATOR_VIEW, TRIGGER_NODE_CREATOR_VIEW, CUSTOM_API_CALL_KEY, - AUTO_INSERT_ACTION_EXPERIMENT, } from '@/constants'; -import { usePostHog } from '@/stores/posthog.store'; import { useUsersStore } from '@/stores/users.store'; import { useWebhooksStore } from '@/stores/webhooks.store'; import { runExternalHook } from '@/utils'; @@ -143,12 +141,8 @@ function onSelected(actionCreateElement: INodeCreateElement) { const isPlaceholderTriggerAction = placeholderTriggerActions.some( (p) => p.key === actionCreateElement.key, ); - const includeNodeWithPlaceholderTrigger = usePostHog().isVariantEnabled( - AUTO_INSERT_ACTION_EXPERIMENT.name, - AUTO_INSERT_ACTION_EXPERIMENT.variant, - ); - if (includeNodeWithPlaceholderTrigger && isPlaceholderTriggerAction && isTriggerRootView) { + if (isPlaceholderTriggerAction && isTriggerRootView.value) { const actionNode = actions.value[0].key; emit('nodeTypeSelected', [actionData.key as string, actionNode]); diff --git a/packages/editor-ui/src/constants.ts b/packages/editor-ui/src/constants.ts index f244280fe0..d21c2b423a 100644 --- a/packages/editor-ui/src/constants.ts +++ b/packages/editor-ui/src/constants.ts @@ -520,12 +520,6 @@ export const KEEP_AUTH_IN_NDV_FOR_NODES = [HTTP_REQUEST_NODE_TYPE, WEBHOOK_NODE_ export const MAIN_AUTH_FIELD_NAME = 'authentication'; export const NODE_RESOURCE_FIELD_NAME = 'resource'; -export const AUTO_INSERT_ACTION_EXPERIMENT = { - name: '003_auto_insert_action', - control: 'control', - variant: 'variant', -}; - export const TEMPLATE_EXPERIMENT = { name: '002_remove_templates', control: 'control', @@ -538,11 +532,7 @@ export const ONBOARDING_EXPERIMENT = { variant: 'variant', }; -export const EXPERIMENTS_TO_TRACK = [ - TEMPLATE_EXPERIMENT.name, - AUTO_INSERT_ACTION_EXPERIMENT.name, - ONBOARDING_EXPERIMENT.name, -]; +export const EXPERIMENTS_TO_TRACK = [TEMPLATE_EXPERIMENT.name, ONBOARDING_EXPERIMENT.name]; export const NODE_TYPES_EXCLUDED_FROM_OUTPUT_NAME_APPEND = [FILTER_NODE_TYPE];