admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(HTTP Request Tool Node): Relax binary data detection (#13048)

Browse Source
This commit is contained in:
oleg
2025-02-05 12:14:31 +01:00
committed by GitHub
parent a7792684a6
commit b67a003e0b
2 changed files with 84 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/@n8n/nodes-langchain/nodes/tools/ToolHttpRequest/utils.ts
View File

@@ -5,7 +5,6 @@ import { JSDOM } from 'jsdom';
import get from 'lodash/get';
import set from 'lodash/set';
import unset from 'lodash/unset';
import * as mime from 'mime-types';
import { getOAuth2AdditionalParameters } from 'n8n-nodes-base/dist/nodes/HttpRequest/GenericFunctions';
import type {
IDataObject,
@@ -146,6 +145,25 @@ const defaultOptimizer = <T>(response: T) => {
return String(response);
};
function isBinary(data: unknown) {
// Check if data is a Buffer
if (Buffer.isBuffer(data)) {
return true;
}
// If data is a string, assume it's text unless it contains null characters.
if (typeof data === 'string') {
// If the string contains a null character, it's likely binary.
if (data.includes('\0')) {
return true;
}
return false;
}
// For any other type, assume it's not binary.
return false;
}
const htmlOptimizer = (ctx: ISupplyDataFunctions, itemIndex: number, maxLength: number) => {
const cssSelector = ctx.getNodeParameter('cssSelector', itemIndex, '') as string;
const onlyContent = ctx.getNodeParameter('onlyContent', itemIndex, false) as boolean;
@@ -755,13 +773,8 @@ export const configureToolFunction = (
if (!response) {
try {
// Check if the response is binary data
if (fullResponse?.headers?.['content-type']) {
const contentType = fullResponse.headers['content-type'] as string;
const mimeType = contentType.split(';')[0].trim();
if (mime.charset(mimeType) !== 'UTF-8') {
throw new NodeOperationError(ctx.getNode(), 'Binary data is not supported');
}
if (fullResponse.body && isBinary(fullResponse.body)) {
throw new NodeOperationError(ctx.getNode(), 'Binary data is not supported');
}
response = optimizeResponse(fullResponse.body);